classicdb / database

Classic DB is a content database for CMaNGOS Classic: world, NPCs, objects, quests and so on.
https://github.com/cmangos/mangos-classic
Other
87 stars 56 forks source link

Bugged quests list #823

Open killerwife opened 8 years ago

killerwife commented 8 years ago

Hello, I have compiled a bugged quests list from Vengeance of Azeroth, with the goal to let u guys know whats bugged. I will be updating this list as I get more data. Should I fix any vanilla quest myself, I will share it with you guys (I only dont release TBC fixes due to competition).

Here is the list https://docs.google.com/spreadsheets/d/1rCCkIpGgatXbnzjiE8X3GsUnGxizaKAeC5s3GqPG-pA/edit?usp=sharing

There are two sheets, first one is straightforward, the second one is full of dubious issues.

I understand that there might be some discrepancies between our databases (we are basically using an update version of TBC-DB, with all UDB ports, and most Classic-DB portS). Should you notice anything thats working on Classic-DB let me know, I will try to make sure that our databases are in sync so that I do not report non existing issues.

In that link I will also make a third sheet of quests that I am actively fixing and I am missing data in TBC. Should anyone have a sniff, or spell data for the mentioned problem, and is willing to share it, let me know. (if the condition will be to make the fix out of that sniff public, I have no issue with that).

In any case, I am on IRC all the time these days, so feel free to contact me.

killerwife commented 8 years ago

Updated on 01.04.2016

cala commented 8 years ago

I got a look at the list. It is quite exhaustive, thanks. However, I think a good bunch of them are already fixed in UDB and Classic DB.

killerwife commented 8 years ago

Yes, I am right now working on some huge missing UDB backports that have 5-6 vanilla quests done. Please notify me here, or come to IRC and i will give you editing rights for that docs.

Also if you could be so kind, check this if its added in Classic db as proper spot. UPDATE creature SET position_x = 5800.89, position_y = -985.82, position_z = 409.78 WHERE guid = 39715; (proper spawn point for kroshius) We made a recent decision to export any fixes we do for vanilla, since there is 0 competition in the cmangos vanilla scene right now.

Muehe commented 8 years ago

Nope, it's 5780.34, -964.844, 412.694.

killerwife commented 8 years ago

Yea, needs to be added to classic as well then :) There is an invisible GO spell focus on the proper spot, so that UPDATE will synch their positions.

Muehe commented 8 years ago

Here are some odd quest ID's I found while checking classicdb. I compared quest_template.entry against creature_involvedrelation, gameobject_involvedrelation, creature_questrelation, gameobject_questrelation and item_questrelation.

I don't think there is any other way of starting and ending a quest, correct? These quests came up:

For example quest 614 is called "The Captain's Chest". There is another quest with this name (8551) which has Captain Hecklebury Smotts as quest start and end, like quest text suggests 614 should have. Looks like someone took one side of the quests chains from Smotts and made them available to both factions, while removing start and end points for alliance side quests. This pattern continues with [615, 8553] and [618, 8554].

According to Objectives text quest 7401 should be finished by Sergeant Yazra Bloodsnarl (13448), quest 7402 should be finished by Corporal Noreg Stormpike (13447) (and have RequiredRaces 77, I'll script up a list with mismatching quest/creature factions one of these days).

That's all I could check so far.

Tobschinski commented 8 years ago

For example quest 614 is called "The Captain's Chest". There is another quest with this name (8551) which has Captain Hecklebury Smotts as quest start and end, like quest text suggests 614 should have. Looks like someone took one side of the quests chains from Smotts and made them available to both factions, while removing start and end points for alliance side quests. This pattern continues with [615, 8553] and [618, 8554].

This is correct, afaik. Quest 8551 was added in patch 1.9 and replaced 614.

Muehe commented 8 years ago

Oh okay. Well, shouldn't 614 etc. be removed from DB then? Or is there any reason to keep them?

killerwife commented 8 years ago

Should anyone embark on some crazy quest to support all versions, it should be kept available for them. I know of a q in TBC that was removed in beta, but is still in the quest_template table and there is even a spell for it

cala commented 8 years ago

@Tobschinski is right: there are many quests that were marked as deprecated in Classic and replaced by another quest doing/asking basically the same thing. Usually, when a NPC proposes the same quest twice, one of them is deprecated. And I think most of the quests listed above with neither start nor end point belong to that deprecated list.

For those that are missing their start or end point, we should investigate further.

Like @killerwife, I disagree with the removal of such quests (and any other deprecated or beta content) because:

Muehe commented 8 years ago

Quest 961 (Onu is meditating)

This quest only becomes available once quest 944 (The Master's Glaive) is active. It resupplies quest item 5251 (Phial of Scrying). The item can also be reobtained by abandoning/accepting the parent quest.

Currently quest 961 is offered for completion (has Method 0) but nothing happens when clicking "Complete Quest" except a sound being played. So yeah, that seems wrong...

Couldn't figure out when it was added but it was removed in 4.0.3a.

Quests 7401/7402 (Wanted: DWARVES!/ORCS!)

Both added in 1.5.0 and removed in 1.10.0. The gameobjects starting them are not spawned, so no problem here.

Quests 7221/7222 (Speak with Prospector Stonehewer/Voggah Deathgrip)

Seems they were replaced with Hero of the Stormpike/Frostwolf in 1.8.0. They have no start point, so no problem here.

General note:

If these quest are kept for later use, shouldn't they be inactivated some other way than removing their start/end points? For example if you fix quest 961 by removing it from creature_questrelation, then this entry will have to be restored when somebody wants to use the quest again. Better way would be to flag quests inactive to the core, so our particular somebody would just have to remove a flag instead of figuring out where these quests started/ended. QuestFlags 16 seems unused (btw. why does quest 8945 have all QuestFlags set? I am pretty sure it is no TBC starting zone nor daily quest fixed in 537d336bdf1f2b04f24058f9c90ee748ad6f5df8).

Zooke commented 8 years ago

I don't know how many of these are already fixed, but in order to clean this up, I'll be working my way through them and listing results here, starting from the bottom.

All quest feedback is from the latest Classic build at the time of testing.

The Sacred Flame - /Fixed Escape Through Force - /Fixed Tome of Valor - She does indeed despawn at the end of the event. /Broken Sully Balloo's Letter - /Fixed Grimtotem Spying - /Fixed Free at Last - /Fixed Foror's Compendium - / #420 Digging Through the Dirt - /Fixed by a hack. Not Blizzlike. The Curse of the Tides - /Fixed Horde Trauma - /Fixed, if anything I found it too easy, all the casualties spawned within a radius that meant I did not have to move. Might need more investigation. Weapons of Choice - /Fixed. Marg Speaks - /Fixed, Drop rate is 5% The Smoldering Ruins of Thaurissan - /Fixed A New Plague - /Fixed Rite of Vision - /Fixed Tools of the Trade - /I don't understand the issue raised, how is the npc connected to this item ? Rescue OOX-22/FE - /Working but needs attention. Robot moves on his side, doesn't stick to the path, should spawned mobs have loot tables ?, some spawned mobs not immediately aggroing, Robot aggro range is way too small, No zooming off at the end. Couldn't find a video of this. Weapons of Spirit - /Working but needs attention. Witch Doctor Uzer'i does not do any crafting before the quest completes. Gerenzo's Orders - /Not scripted Torek's Assault - /Working but needs attention. Guards do not follow Torek, Toreks hp regenerates, Torek cannot be healed (was playing druid). The Exorcism - /Working but needs attention. Tabetha does not move outside to summon. Lard Lost His Lunch - /Working but needs attention. Only 2 mobs spawn instead of 3, mobs do not aggro on spawn. Cleansing Felwood - /Fixed Samophlange Manual - /Fixed Hints of a New Plague? - /Fixed. However this quest highlights a possible issue. Quae is marked as a civilian. Is this correct, I couldn't find any evidence to back this up. Items of power - /Fixed Shy-Rotam - /Working but needs attention. Both Shy and Siam do cast fear a lot. Maybe it was like this on retail, I don't know, but judging from the lack of complaints on wowhead I have to doubt it. Ghost-o-plasm Round Up - /Not scripted Plagued Lands - /Working but needs attention. The quest completes upon capturing the bear, not on the return to Auberdine. Spell 9372 have something to do with this maybe ? Worth its weight in gold - /Fixed. Skuerto offers next quest as he should. A dip in the moonwell - / Quest added after 1.12 Gizelton Caravan / A bodyguard for hire - /Broken. Scripts are in db but player unable to accept quests.

killerwife commented 8 years ago

Thx, I will eventually datamine it from classic-db so it makes it into our local TBC-DB and later into public one one day.

Zooke commented 8 years ago

All quests reviewed for classic ready for separating. @cala

killerwife commented 8 years ago

I told @devildog4355 to do it :) We will update docs later, because we launched a 1x TBC server so shitton of feedback. I am busy fixing draenei/BELF zones atm and syncing with UDB so I cant do everything.

killerwife commented 8 years ago

@Zooke Plagued lands a really tough pickle. The spells used for it in vanilla dont exist in Wotlk and TBC :O

killerwife commented 8 years ago

https://github.com/cmangos/mangos-tbc/pull/64 pullrequest for fixed Plagued Lands

I ran into a few core limitations on the way :)