Practice lockbox fixes

[katz1]

As a rouge of the horde, you are expected to level lockpicking with the Buccaneer's Strongboxes (entry 123330) in the 'lockpicking quest'. These do not work as expected, because they won't despawn after being picked. This means once you open them, they won't grant any more skill increases.

On the alliance side, the rouges pick Practice Lockboxes (entry 178244 and 178246), which do despawn correctly after being picked. It seems this was related to the data2 flag, because setting that for the Buccaneer's Strongboxes made them despawn as expected.

The respawn time of all the boxes were all over the place. The Buccaneer's Strongboxes had a respawn time of 2 seconds, which is way too fast in my opinion. I remember running around on retail for the boxes. On the alliance side three of the boxes had 5 seconds (which is fair), and two of the boxes had 7200 seconds (which is strange). So I set the respawn time of all the boxes to 5 seconds.

[katz1]

I left out some of the Buccaneer's Strongbox variants, which should be fixed by the second commit. There are a 4 Buccaneer's Strongbox and 3 Practice Lockbox variants in total, all should be working now.

The data2 flag for chests translates to: chestRestockTime (time in seconds) I find it a bit strange that even though gameobject 123330 had a checkRestockTIme of 1 second, it did not despawn even after waiting 5 minutes and relogging, making the lockpick leveling really difficult.

Anyways, the lockpick quest is now working for the horde as well.

[Phatcat]

Is there a reason not to squash these two commits?

I see no problem with this, but you probably want @cala to look at this.

[katz1]

Is there a reason not to squash these two commits?

Right you are, I squashed them.

[cala]

Thank you for this pull request and explaining what it does fix. I agree with the changes in the gameobject_template table. I'm not sure that a 5 sec respawn for the chest is correct. That seems a bit short but I can't tell for sure, some GO did respawn that fast. 7200 however is a typical instance respawn time and is clearly wrong here. Also, I think the strongboxes should be pooled but that can be handled elsewhere.

A few guidelines for SQL queries. In the WHERE clause of your SQL query, you can use the IN keyword to avoid a long list of OR. This would change:

`UPDATE `gameobject_template` SET `data2`='0' WHERE `entry`='123330' OR `entry`='123331' OR `entry`='123332' OR `entry`='123333';

To the shorter and more readable:

`UPDATE `gameobject_template` SET `data2`='0' WHERE `entry` IN ('123330', '123331', '123332', '123333');

Also, apostrophe (') is not required when dealing with numbers. In fact, it is usually better to not use them when dealing with numbers unless you are not sure that the fields are indeed of a numerical type.

Finally:

[Phatcat]

https://www.youtube.com/watch?v=XMKCTfAqgOg

At 0.46 - 5 seconds actually seem pretty spot on.

[cala]

So be it! :) In https://github.com/classicdb/database/commit/9cdc781960f23cdf3e21554011e39d5962b8c552, thank you! :+1: