search

classicdb / database

Classic DB is a content database for CMaNGOS Classic: world, NPCs, objects, quests and so on.
https://github.com/cmangos/mangos-classic
Other
87 stars 59 forks source link

Picture in books #881

Closed M2us closed 8 years ago

M2us commented 8 years ago

Added the possibility display images in some books.

cala commented 8 years ago

Thank you for this! I'm leaving for holidays soon, so the reviewing may have to wait for my return, but this looks great. :+1:

Phatcat commented 8 years ago

You should consider doing a new PR for those changes as they seem unrelated. It's looking really good, though. :+1:

evil-at-wow commented 8 years ago

I'm leaving for holidays soon

Oh no, no, that was not in your contract little imp turtle! :stuck_out_tongue:

And this is a lovely change. I've noticed several pictures were missing, but I never took the time to figure out how to show pictures in books, so I learned something today.

In return I'll share some knowledge as well: as you can see, github has the annoying habit of automatically adding new commits you push later to your own repository/branch to a pull request, resulting in multiple unrelated commits being in the same pull request (that's what Phatcat is saying). The only way around that - as far as I know - is creating a separate branch for each pull request in your own repository, one per "topic". Of course, if multiple commits make sense for a single topic, you can of course push multiple commits to that branch. But no harm done, you can still create that extra branch.