search

classicdb / database

Classic DB is a content database for CMaNGOS Classic: world, NPCs, objects, quests and so on.
https://github.com/cmangos/mangos-classic
Other
87 stars 59 forks source link

Non-elite creatures in Stratholme and Scholomance should stop yielding Reputation after Honored with Argent Dawn #884

Closed Neotmiren closed 8 years ago

Neotmiren commented 8 years ago

"Non-elite monsters (except Neutral Shadowmages) stop giving reputation at Honored. Elite monsters stop at Revered" http://wowwiki.wikia.com/Argent_Dawn?oldid=324107

DELETE FROM creature_onkill_reputation WHERE creature_id=10582; -- remove Dog (Freewind Post)

UPDATE creature_onkill_reputation SET MaxStanding1=4 WHERE creature_id IN (10481,10485,10482,10391,10390,10399,10480) AND RewOnKillRepFaction1=529 AND MaxStanding1=5; -- Stop after Honored

UPDATE creature_onkill_reputation SET MaxStanding1=5 WHERE creature_id=8550 AND RewOnKillRepFaction1=529 AND MaxStanding1=4; -- Prolong until Revered
Phatcat commented 8 years ago

DELETE FROM creature_onkill_reputation WHERE creature_id=10582; -- remove Dog (Freewind Post)

Why should this mob not reward any rep at all anymore?

Neotmiren commented 8 years ago

Do you think there should be some amount of Argent Dawn reputation for level 1 Dog in Thousand Needles?

cala commented 8 years ago

Thread moderated. Let's focus on the issue reported here. If one want to discuss the various approaches in contributing, I think the CMaNGOS forums are a more suitable place.

Phatcat commented 8 years ago

I can respect that.

Tobschinski commented 8 years ago

Is 

UPDATE creature_onkill_reputation SET MaxStanding1=4 WHERE creature_id IN (10481,10485,10482,10391,10390,10399,10480) AND RewOnKillRepFaction1=529 AND MaxStanding1=5; -- Stop after Honored

correct?

5 reputation for killing any elite undead and most non-elites in Scholomance and Stratholme (stops at Revered).

Neotmiren commented 8 years ago

Not sure about this "most non-elites" part. It seems like wowwiki formally contradicts to itself within the same page. Yes, the first quote could be badly formulated and be related to non-instanced non-elite only. So I agree this sql part could be not correct and thus should not be applied.

My reason to notice this subject was practical easiness to AoE grind reputation from non-elite creatures at the entrance of Stratholme (repeatedly resetting instance). Too easy for Classic, compared to grinding reputation with other factions.

Tobschinski commented 8 years ago

https://github.com/classicdb/database/commit/43d05f667384d06b55a5d4b6b2148d8deeb33849