search

classicdb / database

Classic DB is a content database for CMaNGOS Classic: world, NPCs, objects, quests and so on.
https://github.com/cmangos/mangos-classic
Other
87 stars 59 forks source link

[1472] Corrected damage range in projectiles #907

Closed Swater96 closed 7 years ago

Swater96 commented 7 years ago

Arrows and bullets with damage values such as 1.5 were being rounded to dmg_min 1 to dmg_max 2 giving incorrect damage against unarmored targets.

I refrenced this report here https://vanilla-twinhead.twinstar.cz/?issue=9783 and did my own calculations below

Min: ((arrow dps + AP/14)_weapon speed + weapon min) Max: ((arrow dps + AP/14)_weapon speed + weapon max)

level 1 NE hunter with rough arrows, target has no armor min = (1.5+48/14)_2.30+2) max = (1.5+48/14)_2.30+5) min = 13.335 max = 16.335

cala commented 7 years ago

Hi,

Thank you for the PR. As I understand it, this is the DB part of an issue that is still under investigation. Said otherwise: are we sure that the ammos must add flat damage?

If so, I think we can merge this.

cala commented 7 years ago

Thank you. In https://github.com/cmangos/classic-db/commit/bf2ef10c25eac14e09b58e7b67b1bc78e19bc21c