classicrocker883 / MRiscoCProUI

This is optimized firmware for Voxelab Aquila & Ender3 V2/S1 3D printers.
https://classicrocker883.github.io/
Other
80 stars 17 forks source link

Question on compiling for GD32 Voxelab Aquila. #19

Closed bstork0807 closed 1 year ago

bstork0807 commented 1 year ago

Not sure this is the correct place for this but I believe I have tried all options when compiling. I have a Voxelab Aquila G32 and I can take you pre-compiled which works great. I just wanted to tweak some stuff and set it in the firmware so I wouldnt have to fix all the settings after reflashing.. What is your recommendation to do this.. I have VScode setup ready to go..

SrgWhoopsie commented 1 year ago

i know im using a different board but i noticed there was not an answer for this above from a couple weeks ago, and i cannot get get the build env do its thing lol marlin vscode error what am i doing wrong?

Lord-Memester commented 1 year ago

i know im using a different board but i noticed there was not an answer for this above from a couple weeks ago, and i cannot get get the build env do its thing lol marlin vscode error what am i doing wrong?

Well, I have to say, if you're using the wrong board, you might want to start there. Try enabling verbose mode and then paste the output in here, or try making an issue in the main Marlin firmware repository.

SrgWhoopsie commented 1 year ago

For what its worth, im not using the wrong board..... i ditched the stock board for the e3 mini, hence why its changed. Considering this is in the platformio.ini file i assumed there would be no issues. Screenshot_20230309_095739.jpg

this issue happens as soon as i open the folder in vscode, doesnt matter if i change board or leave it on the STM32F103RC_creality_maple. This is why im confused, as i dont get this issue when opening any other source code folder for marlin ive downloaded from git only the proui stuff.

Mriscoc reference IMG_20230309_100933.jpg

Classicrocker reference IMG_20230309_101100.jpg

Or have i understood this wrong and mriscoc or classicrockers firmware connot be complied for anything other that a STM32F series chipsets?

Also sorry for the shotty photo, cannot screen grab ATM as im at work.

Lord-Memester commented 1 year ago

I'm realizing I may not be the best person to answer, and we should probably wait for @classicrocker883 to chime in. However, I would like to suggest that you manually type the command to build the firmware in the terminal. I don't remember it off the top of my head, but you can specify which board you want it to build for even if the platformio.ini says something else. Maybe give that a try?

Lord-Memester commented 1 year ago

@Lord-Memester I since fixed this, it should be working fine. Also I posted a couple quick pre releases for testing if you want to check it out.

@classicrocker883 I have since compiled it with Linear Advance under the latest branch, and encountered the same issue. With my very limited time recently, it might be best that you test them yourself, but I can compile it with the debug flag enabled for LA and let you know what I see (if anything).

I saw in the new firmware that it mentioned low e-jerk, though, and am including my EEPROM settings for reference purposes. At this point, @bstork0807 may wish to chime in and provide their own EEPROM settings specific to linear advance (like e-jerk, e-accell, e-max speed, etc.).

bstork0807 commented 1 year ago

I will check this weekend and post. Been crazy busy family and work life.

classicrocker883 commented 1 year ago

@SrgWhoopsie have you changed the Author's name? that error can come up if you change it from STRING_CONFIG_H_AUTHOR "Miguel A. Risco-Castillo (MRiscoC)"

also I haven't yet updated the BTT SKR Mini E3 config files if you are using those. ill get to it and probably by the time you see this youll see an update (but I am primarily working on the Mriscoc-Feb branch so youll see those changes there).

you must have that board under the MOTHERBOARD in Configuration.h, there are differences between each board and it has to match to the default_envs in platformio.ini, as far as i know there are a couple different types of chips for the SKR mini E3, so be sure that chip matches the default_envs.

classicrocker883 commented 1 year ago

@SrgWhoopsie are you trying to compile using STM32F401RC_btt? you must go into ini/stm32-common.ini and comment out using # these two lines line that have "proui" in them Screenshot 2023-03-11 005903

i updated the config files for the SKR mini, so be sure to look them over.

also, if youre using the RC chip type, you may have to disable some features because some options will not fit. go for the least used like NOZZLE_CLEAN

SrgWhoopsie commented 1 year ago

@classicrocker883 so when i first tried compiling i did change author, but since i have left everything as pulled from git, im just tried opening up your feb branch in vscode via github desktop, (i just cloned it to my pc inside git desktop) so its exact as you branch is, i get the failure as soon as vscode opens, then if i copy the config files over from the config folder, and try to compile i still get the same issue,

marlin vscode error i added a screen grab with verbose

to clarify i am using the STM32G0B1RE env as i have the v3, tho i cannot remember if the board has a STM32G0B0RET6 or a STM32G0B1RET6 i forgot to take a photo before installing lol defs a G0 .

ive compiled the latest marlin bugfix for the printer and its running that no issues for the time being, just using DWIN_MARLINUI_PORTRAIT tho i forgot to publish my changes i made on my work laptop to my fork lol. tho a quick make of firmware platform io says ive got a good meat of mem left memory usage

so putting the hash on the proui in the stm32 common fixed it, but does this mean that its not going to load the dependencies for proui when i compile? seems its a dependencies issue with pio from this terminal output
pio_clean_no-proui

if i use the configuration files in the configuration folder for the BTT-SKR_Mini_E3_V3 i get a env_validate error from_config_folder

bstork0807 commented 1 year ago

Attached are my settings.. i only played around with acceleration image

Lord-Memester commented 1 year ago

Attached are my settings.. i only played around with acceleration image

Interesting. Are you sure you never changed E-jerk? The E-jerk default value in my config is 5, located somewhere in line 1,290-1,305. I don't believe I've edited it.


/**
 * Default Jerk limits (mm/s)
 * Override with M205 X Y Z . . . E
 *
 * "Jerk" specifies the minimum speed change that requires acceleration.
 * When changing speed and direction, if the difference is less than the
 * value set here, it may happen instantaneously.
 */
#define CLASSIC_JERK  // Ender Configs
#if ENABLED(CLASSIC_JERK)
  #define DEFAULT_XJERK 10.0  // Ender Configs
  #define DEFAULT_YJERK 10.0  // Ender Configs
  #define DEFAULT_ZJERK  0.3  // Ender Configs
  //#define DEFAULT_IJERK  0.3
  //#define DEFAULT_JJERK  0.3
  //#define DEFAULT_KJERK  0.3
  //#define DEFAULT_UJERK  0.3
  //#define DEFAULT_VJERK  0.3
  //#define DEFAULT_WJERK  0.3

  //#define TRAVEL_EXTRA_XYJERK 0.0     // Additional jerk allowance for all travel moves

  //#define LIMITED_JERK_EDITING        // Limit edit via M205 or LCD to DEFAULT_aJERK * 2  // Ender Configs
  #if ENABLED(LIMITED_JERK_EDITING)
    #define MAX_JERK_EDIT_VALUES { 20, 20, 1, 20 } // ...or, set your own edit limits  // MRiscoC allows higher limits
  #endif
#endif

#define DEFAULT_EJERK    5.0  // May be used by Linear Advance  // Ender Configs```
classicrocker883 commented 1 year ago

here is the thing about proui, it's only for the "DWIN_LCD_PROUI" (ender 3 v2 and Voxelab Aquila full color LCD) the ProUI can't work on the CR10_STOCKDISPLAY. you can use that screen on the skr mini e3, but it requires you to modify the wires (I believe u need to swap two wires) and editing in the firmware.

as for the env_validate error I may have made a mistake editing those files and accidentally uploaded them as I was troubleshooting the issue. because when I compiled to see if everything was good, it was successful.

so if you can before I get a chance, you could copy over those files from the Marlin bugfix and replace them in the Mriscoc-Feb branch. the files being pins/stm32g0/pins_BTT-SKR_Mini_E3_V3_0.h and env_validate.h. if you compare the files they may be different because I copied over one into the other so I could test something. and I think I forgot to undo that.

classicrocker883 commented 1 year ago

@SrgWhoopsie

!! the file isn't even in there no wonder. here is the correct file you need to paste in the pins/stm32g0 folder

yeah those # need to be put infront of the lines with proui in that file or you get that error doing a clean. if you get any output error it's fine, maybe Mriscoc will have it fixed in the next update. so what I do is comment those out, do a clean, restart VS code so it loads the c_cpp_properties file so it automatically updates whatever you enable or disable, and u can remove the # before compiling. and again, proui is only needed when using the color 4.3" LCD.

classicrocker883 commented 1 year ago

just published a new branch 2023-March i was able to make a successful compile, the update just came out so i haven't been able to do any testing yet.

bstork0807 commented 1 year ago

I do have ejerk set to 5.. u can check my code below https://github.com/bstork0807/MriscocProUI-For-Bills-Aquila-

classicrocker883 commented 1 year ago

I do have ejerk set to 5.. u can check my code below https://github.com/bstork0807/MriscocProUI-For-Bills-Aquila-

there is a setting in LIN_ADVANCE in the config_adv.h file that says ALLOW_LOW_EJERK which allows less than 10 recommended for direct drive. I wish I knew more about this in context, as to what setting would be better with Bowden vs direct drive, and with or without linear advance. so I just am guessing that perhaps higher EJERK will be better with linear advance? i dont know, i haven't gone so much into testing it all, especially when they keep updating everything.

another thing is Junction Deviation. that can be enabled when CLASSIC_JERK is disabled. also, EXPERIMENTAL_SCURVE has been removed from LIN_ADVANCE options, again, i wish i knew the whole process of why it was there and why it was removed, and benefits or disadvantages with S_CURVE_ACCELERATION with Linear Advance. there should be a whole write up about this, like a change log or something detailing the options and thought process of each setting and what it means when we enable/disable, and what value it should be set at.

Lord-Memester commented 1 year ago

again, i wish i knew the whole process of why it was there and why it was removed, and benefits or disadvantages with S_CURVE_ACCELERATION with Linear Advance. there should be a whole write up about this, like a change log or something detailing the options and thought process of each setting and what it means when we enable/disable, and what value it should be set at.

Do you mean that you believe there is already a changelog or that you think someone should make one?

Lord-Memester commented 1 year ago

A recent update to marlin claims to have fixed the issues with LA, and after checking the repo just now, there haven't been any new issues created about Linear Advance. They closed 52 issues and merged a bunch of fixes!

Have you merged them into this project yet?

(@classicrocker883)
classicrocker883 commented 1 year ago

I merged the most recent Marlin bugfix into the repo - its 2023-May, its the default. let me know how it goes, ill be working on getting .bin files made.

Lord-Memester commented 1 year ago

I merged the most recent Marlin bugfix into the repo - its 2023-May, its the default. let me know how it goes, ill be working on getting .bin files made.

My own build seems to not die. I've only run the same tuning file twice so far, and I need to change my config back to get the bed back to normal, but I'd say I'm currently cautiously optimistic. LA doesn't seem to have any issues on my printer since the merge, but I haven't tested it sufficiently to say it works for sure.

Lord-Memester commented 1 year ago

@classicrocker883 @bstork0807 do we want to close this issue for the time being and move to the recently created discussion instead? Seems like it's serves it's original purpose as an issue and then some.

classicrocker883 commented 1 year ago

yes thanks for the reminder

classicrocker883 commented 1 year ago

also, as for a change log, I'll leave that to Mriscoc, when he posts his next update, hopefully soon, I'll make a link to that.

as for anything I change I'll write in the Release when new firmware .bin files are made. I'll try to mention the important things, and little changes could be seen in the commit history.

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.