search

classicrocker883 / MRiscoCProUI

This is optimized firmware for Voxelab Aquila & Ender3 V2/S1 3D printers.
https://classicrocker883.github.io/
Other
79 stars 17 forks source link

Input shaping menu shows X frequency for Y #22

Closed KimmoHop closed 1 year ago

KimmoHop commented 1 year ago

Description

Fixes showing Y frequency in input shaping menu

Related Issues

https://github.com/classicrocker883/MriscocProUI/issues/21

Lord-Memester commented 1 year ago

Oh! So that's where I edit dwin.cpp. Thanks for your unintended helping me out! (And also your intended help. I haven't ventured into input shaping yet, but it's good to know that if I do it won't be impossible to understand.)

classicrocker883 commented 1 year ago

hey nice catch. I'll relay the information over to Mriscoc. I'll have this fixed for next update. but if anyone is looking to have the correct values, I believe you can set them via Gcode commands rather than through the LCD UI screen.

KimmoHop commented 1 year ago

The value is editable in UI and will show correct value until you back out to previous menu. I also haven't flashed it after I saw in terminal that correct value is saved (and most likely used ;) ) in EEPROM.

I was on the edge to which repository make the fix :) This seemed to be closer to stock Marlin in latest commits.

Lord-Memester commented 1 year ago

Why's this still show as an open PR?

classicrocker883 commented 1 year ago

Why's this still show as an open PR?

I'm not very familiar with the all these functions like merge and pull and push. I edited it manually, mainly so I know it's done correctly. but I made a comment in an update showing the change was made.