search

classicrocker883 / MRiscoCProUI

This is optimized firmware for Voxelab Aquila & Ender3 V2/S1 3D printers.
https://classicrocker883.github.io/
Other
82 stars 17 forks source link

[BUG] Cancelling build mesh requires restart before being able to rebuild another mesh #92

Closed vw72 closed 7 months ago

vw72 commented 9 months ago

Did you test the latest release build?

Yes, and the problem still exists.

Bug Description

Install December firmware - preheat printer and auto-build mesh. Press cancel during the mesh building. Subsequent attempts to auto-build mesh start but stop immediately with mesh cancelled message. Reboot printer and mesh building works as expected until cancelled, then you need to restart again to build a mesh.

Printer Model

Voxelab Aquila

Model Type

OG

Your Mainboard

Aquila GD32

Other Mainboard Type

No response

Add-ons that could be involved

BL Touch

ProUI?

ProUI

Bed Leveling

UBL - Unified Bed Leveling

Did you include your own configuration files?

Additional information & file uploads

I'm using a Creality display with the TJC chipset on the Voxelab, but I don't think it is related to this issue.

classicrocker883 commented 9 months ago

I'll take a look into this.

classicrocker883 commented 8 months ago

do you know if this had been fixed with the most recent release? if not I can make a test file with a change which might help

vw72 commented 8 months ago

I’m not at the printer tonight but will test it in the morning and report back. Sent from my iPhoneOn Jan 19, 2024, at 5:47 PM, Andrew @.***> wrote: do you know if this had been fixed with the most recent release? if not I can make a test file with a change which might help

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

vw72 commented 8 months ago

Actually, I'm in the middle of a big printjob. As soon as it is done I'll install the latest version and see if it still is a problem. (Version I reported it on was 20231221)

On Fri, Jan 19, 2024 at 5:47 PM Andrew @.***> wrote:

do you know if this had been fixed with the most recent release? if not I can make a test file with a change which might help

— Reply to this email directly, view it on GitHub https://github.com/classicrocker883/MRiscoCProUI/issues/92#issuecomment-1901321154, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAKGTRE477XGY4KM3KJAIMTYPMAYBAVCNFSM6AAAAABBA7T5NWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBRGMZDCMJVGQ . You are receiving this because you authored the thread.Message ID: @.***>

vw72 commented 8 months ago

The problem with cancelling building the mesh keeping you from being able to go back and build a mesh persists on the January release. Once you cancel the building if the mesh, you need to restart the printer to be able to build the mesh. JoePs. On TJC still can’t preview gcode regardless of which slicer created the gcode and image, including Cura, Prusaslicer and Orcaslicer. Sent from my iPhoneOn Jan 20, 2024, at 1:48 PM, Joseph Braddock @.> wrote:Actually, I'm in the middle of a big printjob. As soon as it is done I'll install the latest version and see if it still is a problem.  (Version I reported it on was 20231221)On Fri, Jan 19, 2024 at 5:47 PM Andrew @.> wrote: do you know if this had been fixed with the most recent release? if not I can make a test file with a change which might help

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

classicrocker883 commented 8 months ago

if im not mistaken, some TJC displays may not work with gcode preview. I'm actually not sure theres not much info I can find about it Reddit post about this

I think for TJC you may need to use 180x180 , try that in the slicer.

classicrocker883 commented 8 months ago

are you able to compile your own?
in src/lcd/e3v2/proui/dwin.cpp

look for and add this to the function:

  void DWIN_LevelingDone() {
    DEBUG_ECHOLNPGM("DWIN_LevelingDone");
    #if HAS_MESH
      #if ALL(PROUI_EX, HAS_BED_PROBE)
        ProEx.LevelingDone();
      #else
        Goto_MeshViewer(true);
      #endif
    #endif
+   HMI_ReturnScreen();
  }
vw72 commented 8 months ago

I’ve tried 180x180 and 160x160 for both jpg and png.  It used to work prior to the December firmware. It gives the message 200x200 preview not found or something like that regardless of what size I choose. I think previously it just said no preview found. I’m going to try reverting back to the the October or November firmware and see if I can get it still works there. It’s not show stopper just a nice feature to have. JoeSent from my iPhoneOn Jan 21, 2024, at 4:30 AM, Andrew @.***> wrote: if im not mistaken, some TJC displays may not work with gcode preview. I'm actually not sure theres not much info I can find about it Reddit post about this I think for TJC you may need to use 180x180 , try that in the slicer.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

vw72 commented 8 months ago

The preview works with TJC on the 20231027 version of the firmware; Aquila-TJC_GD32_UBL-ProUI2.1.3e-2.2.binDo you want me to open a separate bug report since this one is about the bed mesh? Also on this version you can cancel the bed mesh and the run it again and it works as expected (you don’t have to restart the printer). JoeSent from my iPhoneOn Jan 21, 2024, at 4:30 AM, Andrew @.***> wrote: if im not mistaken, some TJC displays may not work with gcode preview. I'm actually not sure theres not much info I can find about it Reddit post about this I think for TJC you may need to use 180x180 , try that in the slicer.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

vw72 commented 8 months ago

Currently I’m not in a position to compile it. My work around is just not to cancel the mesh or if I do just restart the printer and reheat the bed. It’s a minor inconvenience. Sent from my iPhoneOn Jan 21, 2024, at 4:42 AM, Andrew @.***> wrote: are you able to compile your own? in src/lcd/e3v2/proui/dwin.cpp look for and add this to the function: void DWIN_LevelingDone() { DEBUG_ECHOLNPGM("DWIN_LevelingDone");

if HAS_MESH

  #if ALL(PROUI_EX, HAS_BED_PROBE)
    ProEx.LevelingDone();
  #else
    Goto_MeshViewer(true);
  #endif
#endif

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

classicrocker883 commented 8 months ago

Hi I am very close to this fix. So far I have been able to cancel normally, and re-level without restarting.
One thing I'm hung up on is when you press the button to cancel. it seems as though the button must be pressed at the right moment (like when its "not busy").

its a bit tricky to figure out since the code in question resides within the proui library - which are compiled files you cant just open and change, actually you cant even read them because its protected in a way.

so soon, I'm so close. also I mentioned in another comment asking about the TJC display, if there is an issue setting the value that isnt between 0-100. or 101-200. setting brightness should be linear. and I should have a fix next release.

and if you had any other recommendations what I can do that would help.

classicrocker883 commented 8 months ago

The preview works with TJC on the 20231027 version of the firmware

oh no... I think this is when we had fixed the issue regarding the preview - anytime you would click it more than a few times it would freeze and restart. what I can do is when TJC is enabled, I'll have it use that code set which worked for that.

oh also, did I mention this somewhere else? try changing the preview thumbnails to 180x180. in the "slicer scripts", in CreateJPEGThumbnail.py, look for "default_value": 200, and make it 180 for height and width [this is for Cura]
for PrusaSlicer you should be able to change it in the slicer settnigs.

if that doesnt work...I may have to change that in firmware. otherwise, I believe I need to have it use that the preview gcode preview thumbnail code from October

vw72 commented 8 months ago

I can’t get to it today (Friday) because I’m in the middle of a big print. I should be able to text it tomorrow (Saturday). I’ll report back afterwards. I’d it located in the regular GitHub area?

Joe

On Fri, Jan 26, 2024 at 7:10 AM Andrew @.***> wrote:

Hi I am very close to this fix. So far I have been able to cancel normally, and re-level without restarting. One thing I'm hung up on is when you press the button to cancel. it seems as though the button must be pressed at the right moment (like when its "not busy").

its a bit tricky to figure out since the code in question resides within the proui library - which are compiled files you cant just open and change, actually you cant even read them because its protected in a way.

so soon, I'm so close. also I mentioned in another comment asking about the TJC display, if there is an issue setting the value that isnt between 0-100. or 101-200. setting brightness should be linear. and I should have a fix next release.

and if you had any other recommendations what I can do that would help.

— Reply to this email directly, view it on GitHub https://github.com/classicrocker883/MRiscoCProUI/issues/92#issuecomment-1912046113, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAKGTRBAC63HRVO67KVNO43YQOTMZAVCNFSM6AAAAABBA7T5NWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSGA2DMMJRGM . You are receiving this because you authored the thread.Message ID: @.***>

vw72 commented 8 months ago

That would be great but if I’m the only one noticing the problem, it might be easier on your end to just say the preview doesn’t work on TJC. It’s nice to have but by no means a show stopper.

On Fri, Jan 26, 2024 at 7:13 AM Andrew @.***> wrote:

The preview works with TJC on the 20231027 version of the firmware

oh no... I think this is when we had fixed the issue regarding the preview

  • anytime you would click it more than a few times it would freeze and restart. what I can do is when TJC is enabled, I'll have it use that code set which worked for that.

— Reply to this email directly, view it on GitHub https://github.com/classicrocker883/MRiscoCProUI/issues/92#issuecomment-1912049107, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAKGTRG3NQM5CFLMPA73QH3YQOTWBAVCNFSM6AAAAABBA7T5NWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSGA2DSMJQG4 . You are receiving this because you authored the thread.Message ID: @.***>

classicrocker883 commented 8 months ago

I have something you can test, its TJC-GD32_UBL-ProUI.bin it also has some code I'm testing canceling the build mesh.

let me know if the gcode preview works.
Aquila-TJC-GD32_UBL-ProUI.zip

vw72 commented 8 months ago

This did not fix the gcode preview but it did fix the cancelling the build mesh. Also, unlike the other TJC versions, the control knob is scrolling backwards on this one.

With the exception of the preview, from what I can tell, the difference between the TJC and the DWIN, from a user perspective is the direction the control knob scrolls. Is that something that can be placed in a setting under advanced to keep you from having to compile two versions?

Joe

On Fri, Jan 26, 2024 at 10:04 AM Andrew @.***> wrote:

I have something you can test, its TJC-GD32_UBL-ProUI.bin it also has some code I'm testing canceling the build mesh.

let me know if the gcode preview works. Aquila-TJC-GD32_UBL-ProUI.zip https://github.com/classicrocker883/MRiscoCProUI/files/14066927/Aquila-TJC-GD32_UBL-ProUI.zip

— Reply to this email directly, view it on GitHub https://github.com/classicrocker883/MRiscoCProUI/issues/92#issuecomment-1912304369, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAKGTRDKOPI6ITO3BJIDNITYQPHX5AVCNFSM6AAAAABBA7T5NWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSGMYDIMZWHE . You are receiving this because you authored the thread.Message ID: @.***>

classicrocker883 commented 8 months ago

oh that's right I forgot about it being TJC, Aquila displays have it reverse and I forgot to comment that line out.

well that sucks about the gcode preview... I had it reverted back since before the change, like u said was back in October. maybe I missed something.

When u mention when it worked, were u using 200x200 thumb size in slicer? have you tried Both Cura and Prusaslicer?

did I mention the slicer scripts have been updated? perhaps if you updated your slicer, maybe the scripts were lost/deleted. or maybe the new scripts aren't working properly for the TJC.

anyway I should have another release build any day. I think I improved the mesh canceling a tad since.

classicrocker883 commented 7 months ago

https://github.com/classicrocker883/MRiscoCProUI/releases/tag/2.1.3f-2

here is the new release. ill make a list of changes later, let me know if anything needs adjusting

github-actions[bot] commented 5 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.