search

classilla / overbitenx

Because Firefox isn't complete without Gopherspace.
gopher://gopher.floodgap.com/
Other
66 stars 4 forks source link

Gopherpedia articles with spaces in titles render incorrectly #5

Closed Aicaya closed 5 years ago

Aicaya commented 5 years ago

Still new to gopher sites in general so I don't know if it applies to more, but in the case of Gopherpedia, if an article has a space in it then it will throw a lot of errors and generally not render properly (articles with only one word in the title render fine). Pages render correctly on other browsers such as lynx and gopherus, so it's not an issue with the site.

Compare: gopher://gopherpedia.com/0/Wendigo gopher://gopherpedia.com/0/Hollow Knight

Or just browse the site and play around a tad. Pattern holds.

If it helps, the links display correctly in the Floodgap proxy via OverbiteWX. Only difference I can see is that it uses the actual space character instead of %20, but the link in lynx and gopherus has %20 instead of the space character so that shouldn't be a factor. I think.

classilla commented 5 years ago

I can reproduce. Looks like we're failing to deURL escape the selector. The actual transmitted request is gopherpedia.com/Hollow%20Knight, not gopherpedia.com/Hollow Knight, so this likely indicates a front-end Jasper issue. Thanks for the report.

classilla commented 5 years ago

Oh, and as a polite request: if you make any future bug reports, please include what you see in the Browser Console. In this case, the encoded request was there, so that made finding the actual problem much simpler.

classilla commented 5 years ago

Pushed to AMO