search

classilla / tenfourfox

Mozilla for Power Macintosh.
http://www.tenfourfox.com/
Other
276 stars 42 forks source link

Title bar glitches [new chrome] #16

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The title bar colour doesn't match without the tab bar.

https://bugzilla.mozilla.org/show_bug.cgi?id=618770
https://bugzilla.mozilla.org/show_bug.cgi?id=616232

We particularly need to watch for the call in M616232 c7 -- we should just stub 
that out and WONTFIX it for 10.4.

The most recent internal builds for 10.4Fx have an occasional flash of the 
window titlebar line. I'm not sure why. It may be troublesome to fix while this 
code is broken.

Original issue reported on code.google.com by classi...@floodgap.com on 14 Dec 2010 at 5:48

GoogleCodeExporter commented 9 years ago 
beta 9 made the flicker really, really bad, so I changed nsCocoaWindow.mm. In 
RepeatedPatternDrawCallback, we disable the gradient for the titlebar and 
simply draw in windowFrameColor. This looks identical to beta 8 and no longer 
flickers. The window does not properly recolour when inactive, but this is 
shippable. Leaving open to think of what more to do, possibly adjust the alpha 
to be reasonably matchy.

Original comment by classi...@floodgap.com on 9 Jan 2011 at 6:57

GoogleCodeExporter commented 9 years ago 
Alpha adjusted. We'll deal with the inactive window later. Hatch left to use 
Mozilla's code for 10.5.

Original comment by classi...@floodgap.com on 10 Jan 2011 at 2:51

GoogleCodeExporter commented 9 years ago 
Related, though not sure if this is the same bug:

https://bugzilla.mozilla.org/show_bug.cgi?id=621762

Original comment by classi...@floodgap.com on 18 Jan 2011 at 5:46

GoogleCodeExporter commented 9 years ago 
Switched back to Mozilla's code for b11, but the rest still apply.

Original comment by classi...@floodgap.com on 2 Feb 2011 at 6:42

GoogleCodeExporter commented 9 years ago 
Doesn't look like Mozilla is going to fix this for final.

Original comment by classi...@floodgap.com on 10 Mar 2011 at 2:09

GoogleCodeExporter commented 9 years ago 
Dropping to Low. This has few complaints, and most people use the unified look 
which does work.

Original comment by classi...@floodgap.com on 30 May 2011 at 4:24

GoogleCodeExporter commented 9 years ago 
This is affected by the CoreUI changes in 83. I might just close this into that 
one, but we'll see.

Original comment by classi...@floodgap.com on 16 Aug 2011 at 6:04

GoogleCodeExporter commented 9 years ago 
issue 83 does indeed make this worse (backing out the CoreUI changes), so this 
is now our bug.

We should solve for the default state where the tab bar doesn't collapse when 
there is just one tab. The other is probably not resolvable with the current 
code and I think I'll just wontfix that.

Original comment by classi...@floodgap.com on 3 Oct 2011 at 4:10

GoogleCodeExporter commented 9 years ago 
We just need to overhaul our chrome entirely. A brushed metal theme seems best. 
We will do this when 10.5 support ends in native tree because we will be split 
off separately by then.

Original comment by classi...@floodgap.com on 19 May 2012 at 1:31

GoogleCodeExporter commented 9 years ago 
This is more of an issue purely around issue 247, and less of a concern in 
Australis.

Original comment by classi...@floodgap.com on 25 May 2014 at 5:42