search

classilla / tenfourfox

Mozilla for Power Macintosh.
http://www.tenfourfox.com/
Other
268 stars 38 forks source link

Nuke Telemetry::* from orbit #334

Open classilla opened 7 years ago

classilla commented 7 years ago

Using dummy preprocessor macros in toolkit/components/telemetry for things like Telemetry::Accumulate, we should be able to eliminate much dead code.

It's the only way to be sure.

classilla commented 7 years ago

First cut at this reduced XUL down only by about 300K. Substantial changes were needed for anything that calls Services.telemetry and I still have to look at JS in devtools/.

Since tele isn't being called in hot loops there is probably a small win here but it feels like only an incremental one and the changes required are massive. I'd rather introduce the whole thing for an FPR release. For 45.6 let's just yank it from the UI facing sections:

classilla commented 7 years ago

hg revert --no-backup browser/components/nsBrowserGlue.js browser/base/content/tabbrowser.xml browser/base/content/browser.js

classilla commented 7 years ago

This doesn't include devtools. no_tele.diff.txt

classilla commented 7 years ago

Did the 45.6 parts. Looking at GC/CC for 45.7 or .8.

roytam1 commented 4 years ago

do newer commits pushed? latest rev is 0761d95 right now and tabbrowser.xml changes are missing.

classilla commented 4 years ago

I didn't make any further changes to it.

roytam1 commented 4 years ago

isn't telemetrystopwatch calls in tabbrowser.xml stop running when it is not imported in browser.js?