classlinkinc / angular-material-time-picker

Material design time picker for 12 and 24 hour time.
MIT License
49 stars 30 forks source link

Meridiem Selector & clock button appear editable when read-only="true" #19

Closed cbacon91 closed 6 years ago

cbacon91 commented 7 years ago

When the meridiem selector is available but the directive is marked as read-only, the user can still click on the meridiem selector, but not make any choices. It would look better if this was not clickable at all - md-select has a disabled option to disable this.

Additionally, when the directive is in read-only, the clock icon has cursor: pointer, even though it's not editable. This should probably be set to cursor: default to stay consistent with md-datepicker.

Codepen of the issues:

https://codepen.io/cbacon91/pen/wqBrgY

Andreasbaaserud commented 7 years ago

Good points, I will apply the fixes below for release 1.0.8