search

classmethod / gradle-aws-plugin

Gradle plugin to manage Amazon Web Services
276 stars 131 forks source link

this change has introduced a bug: now ProfileCredentialsProvider is only added if profileName is explicitly specified. In my setup I use profiles, but I don't want to specify it in build.gradle, instead I have AWS_PROFILE env variable set. This used to work and no longer does, so I had to downgrade to 0.39 for now #179

Closed fedork closed 4 years ago

fedork commented 4 years ago

this change has introduced a bug: now ProfileCredentialsProvider is only added if profileName is explicitly specified. In my setup I use profiles, but I don't want to specify it in build.gradle, instead I have AWS_PROFILE env variable set. This used to work and no longer does, so I had to downgrade to 0.39 for now

_Originally posted by @fedork in https://github.com/classmethod/gradle-aws-plugin/pull/176/review_comment/create_

fedork commented 4 years ago

@dai0304 @ImFlog could you take a look and get this fixed? For now I have to downgrade to 0.39... I guess I could make a PR myself if that helps, let me know

dai0304 commented 4 years ago

OK, I'll revert #176 on #180.

@ImFlog Re-PR is welcome

ImFlog commented 4 years ago

I think the issue comes from the fact that the DefaultAWSCredentialsProviderChain was removed and uses the ProfileCredentialsProvider() in the provider chain. I'm pushing a new PR to fix this by appending new providers to the default one. Sorry for the issue @fedork