classmodel / class-web

Web version of CLASS
https://classmodel.github.io/class-web
GNU General Public License v3.0
0 stars 0 forks source link

Replace jest with test:node + add playwright #11

Closed sverhoeven closed 1 month ago

sverhoeven commented 1 month ago

Coverage did work as expected node --import tsx --test --experimental-test-coverage src/*.test.ts Prints coverage in js land and gives error when run with pnpm

Peter9192 commented 1 month ago

Could you try again with

node --version
v20.16.0
rm -rf node_modules/ */*/node_modules
pnpm install
cd packages/class

I was on v20.11, switching to v20.16 and re-installing solved the issue. Thanks!

sverhoeven commented 1 month ago

Could you try again with

node --version
v20.16.0
rm -rf node_modules/ */*/node_modules
pnpm install
cd packages/class

I was on v20.11, switching to v20.16 and re-installing solved the issue. Thanks!

Nice, I added https://github.com/classmodel/class-web/blob/ee9d466e89c16591477ea613d017658750fdc542/packages/class/package.json#L24C2-L26C4 which gives a warning during install. I can make it an errror by adding enginesStrict:true.