classmodel / class-web

Web version of CLASS
https://classmodel.github.io/class-web
GNU General Public License v3.0
0 stars 0 forks source link

Refactor experiments #13

Closed Peter9192 closed 3 weeks ago

Peter9192 commented 1 month ago

Also:

Todo:

Fixes #12

sverhoeven commented 1 month ago

TODO response

  1. I changed the initial open to be when output is missing.
  2. The dialogs that are not open are no part of the dom, they are only in js. Also the dialog component uses a portal. So what you are saying (reusing dom) is already happening.
Peter9192 commented 1 month ago

2. The dialogs that are not open are no part of the dom, they are only in js. Also the dialog component uses a portal. So what you are saying (reusing dom) is already happening.

Cool, thanks! I didn't realize that.

Peter9192 commented 3 weeks ago

Added flex wrap, refs #22

Not quite happy yet with the editable text: it should always focus on the input field when 'editing' is truthy. But I'm not sure we will keep it anyway, so not spending more time optimizing it.

Let's merge this and continue in follow-up PRs.