classtranscribe / FrontEnd

The React + Redux Frontend for ClassTranscribe
https://classtranscribe.illinois.edu
Other
26 stars 28 forks source link

Add glossary to inote #548

Closed aarya-bhatia closed 1 year ago

aarya-bhatia commented 1 year ago

Fixed issue #544 and #545

angrave commented 1 year ago

From "view raw logs" in the build -

023-02-02T15:08:13.8659310Z /home/runner/work/FrontEnd/FrontEnd/src/screens/EPub/controllers/file-builders/GlossaryCreator.js
2023-02-02T15:08:13.8745117Z ##[error]  78:3  error  Unexpected console statement  **no-console**
2023-02-02T15:08:13.8747085Z 
2023-02-02T15:08:13.8747847Z /home/runner/work/FrontEnd/FrontEnd/src/screens/EPub/controllers/file-builders/HTMLFileBuilder.js
2023-02-02T15:08:13.8748986Z ##[error]  242:17  error  **'splitted' is already declared** in the upper scope  no-shadow
2023-02-02T15:08:13.8749579Z 
sujitv19196 commented 1 year ago

I think some work and additional testing is still needed before I would feel confident merging this. We are close though.

angrave commented 1 year ago

Can we close this draft PR?

aarya-bhatia commented 1 year ago

Can we close this draft PR?

We are close to finishing this, minor changes left.

angrave commented 1 year ago

Since there are conflicts, I suggest you close this PR and create a new one when you ready. Suggest you do a rebase on the current staging branch

aarya-bhatia commented 1 year ago

Member

No problem, we can do that.

angrave commented 1 year ago

Closing this PR because there are conflicts in src/screens/EPub/controllers/file-builders/EPubFileBuilder.js src/screens/Glossary/components/GlossaryTable/index.js with the current version of these files.