search

classtranscribe / FrontEnd

The React + Redux Frontend for ClassTranscribe
https://classtranscribe.illinois.edu
Other
26 stars 28 forks source link

changed label for disable glossary to turn off glossary #591

Closed aarya-bhatia closed 1 year ago

aarya-bhatia commented 1 year ago

Do you mean it would be a better idea to turn off the glossary by default and reflect this with the variable names? The menu would have a button to include the glossary then, rather disable it right?

angrave commented 1 year ago

No, it should be on default.

-- So this just removing the word "disable" from the code and UI.

And making checked checkbox a positive thing ie is included.

From: Aarya Bhatia @.> Sent: Friday, March 24, 2023, 6:51 PM To: classtranscribe/FrontEnd @.> Cc: Angrave, Lawrence @.>; Comment @.> Subject: Re: [classtranscribe/FrontEnd] changed label for disable glossary to turn off glossary (PR #591)

Do you mean it would be a better idea to turn off the glossary by default and reflect this with the variable names? The menu would have a button to include the glossary then, rather disable it right?

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/classtranscribe/FrontEnd/pull/591*issuecomment-1483602406__;Iw!!DZ3fjg!5l46TSS3QTC3x7ujDfqRwpg48bM6dqVlDf0eUIblYsEs2p1tVOVhfecwz6Jn8ZotRk1M32-oiG2F0fkjaZCVNi08DdY$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABCC52AXMJW45OSZCQ5RTATW5YXRLANCNFSM6AAAAAAWHC77QU__;!!DZ3fjg!5l46TSS3QTC3x7ujDfqRwpg48bM6dqVlDf0eUIblYsEs2p1tVOVhfecwz6Jn8ZotRk1M32-oiG2F0fkjaZCV-CB-jLQ$. You are receiving this because you commented.Message ID: @.***>

aarya-bhatia commented 1 year ago

No, it should be on default. … -- So this just removing the word "disable" from the code and UI. And making checked checkbox a positive thing ie is included. ____ From: Aarya Bhatia @.> Sent: Friday, March 24, 2023, 6:51 PM To: classtranscribe/FrontEnd @.> Cc: Angrave, Lawrence @.>; Comment @.> Subject: Re: [classtranscribe/FrontEnd] changed label for disable glossary to turn off glossary (PR #591) Do you mean it would be a better idea to turn off the glossary by default and reflect this with the variable names? The menu would have a button to include the glossary then, rather disable it right? — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/https://github.com/classtranscribe/FrontEnd/pull/591*issuecomment-1483602406;Iw!!DZ3fjg!5l46TSS3QTC3x7ujDfqRwpg48bM6dqVlDf0eUIblYsEs2p1tVOVhfecwz6Jn8ZotRk1M32-oiG2F0fkjaZCVNi08DdY$>, or unsubscribe<https://urldefense.com/v3/https://github.com/notifications/unsubscribe-auth/ABCC52AXMJW45OSZCQ5RTATW5YXRLANCNFSM6AAAAAAWHC77QU;!!DZ3fjg!5l46TSS3QTC3x7ujDfqRwpg48bM6dqVlDf0eUIblYsEs2p1tVOVhfecwz6Jn8ZotRk1M32-oiG2F0fkjaZCV-CB-jLQ$>. You are receiving this because you commented.Message ID: @.***>

Okay, I understand now. Thanks for the feedback!