Closed meg-ghana closed 1 year ago
Will look at this soon 👀
@sujitv19196 Sujit; please review!
@sujitv19196 (andothers) Can you take a look at this broken build? I assume the build is broken because packages have changed (not because of the requested js changes in this PR)
2023-06-08T22:05:13.4844518Z warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
There's a ton of warnings for workbox-webpack-plugin from the github actions build-
2023-06-08T22:05:15.0303644Z warning react-scripts > workbox-webpack-plugin@6.6.1: this package has been deprecated 2023-06-08T22:05:32.5175156Z error workbox-webpack-plugin@6.6.1: The engine "node" is incompatible with this module. Expected version ">=16.0.0". Got "14.21.3" 2023-06-08T22:05:32.5176821Z error Found incompatible module.
@sujitv19196 (andothers) Can you take a look at this broken build? I assume the build is broken because packages have changed (not because of the requested js changes in this PR)
2023-06-08T22:05:13.4844518Z warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
There's a ton of warnings for workbox-webpack-plugin from the github actions build-
2023-06-08T22:05:15.0303644Z warning react-scripts > workbox-webpack-plugin@6.6.1: this package has been deprecated 2023-06-08T22:05:32.5175156Z error workbox-webpack-plugin@6.6.1: The engine "node" is incompatible with this module. Expected version ">=16.0.0". Got "14.21.3" 2023-06-08T22:05:32.5176821Z error Found incompatible module.
Id say that we should ignore the error for now. It all still compiles and runs fine. The real issue is that many of the packages are out of date. I can make this its own PR.
@sujitv19196 It was a hard error (fail on the CI step) not a warning. I'm going to rerun the CI build to see if it was just a transient issue... It was not -See raw logs here- https://github.com/classtranscribe/FrontEnd/actions/runs/5216119500/jobs/9435465131
2023-06-09T20:12:54.7247870Z error workbox-webpack-plugin@6.6.1: The engine "node" is incompatible with this module. Expected version ">=16.0.0". Got "14.21.3"
(Not sure why it is using workbox 6.6.1; the package lock and yarn specify 4.2.0 for workbox-webpack-plugin) https://github.com/classtranscribe/FrontEnd/blob/staging/package-lock.json https://github.com/classtranscribe/FrontEnd/blob/staging/yarn.lock
@sujitv19196 It was a hard error (fail on the CI step) not a warning. I'm going to rerun the CI build to see if it was just a transient issue... It was not -See raw logs here- https://github.com/classtranscribe/FrontEnd/actions/runs/5216119500/jobs/9435465131
2023-06-09T20:12:54.7247870Z error workbox-webpack-plugin@6.6.1: The engine "node" is incompatible with this module. Expected version ">=16.0.0". Got "14.21.3"
(Not sure why it is using workbox 6.6.1; the package lock and yarn specify 4.2.0 for workbox-webpack-plugin) https://github.com/classtranscribe/FrontEnd/blob/staging/package-lock.json https://github.com/classtranscribe/FrontEnd/blob/staging/yarn.lock
After much trial and error I am still not able to fix this issue. Really not sure what the root issue is. Maybe we bump the node version to fix.
After successfully building on a linux system (yarn install then build) I found the cause; This was in our ci.yaml (github actions) "yarn global add react-scripts"
# may not be compatible with our version of node
Okay ci.yaml now completes (after removing the unwanted global add react scripts ) FWIW there was a lint error ... which I fixed.
@sujitv19196 Can you close your review?
@sujitv19196 Can you close your review?
On it!
Also didn't realize that the add react-scripts was not needed 😠😠ðŸ˜
Added a feature to enforce the chapter's word count based on a user defined input. Fixed error where first chapter didn't match the word count, and changed original minimum character count to a minimum word count.