search

classtranscribe / FrontEnd

The React + Redux Frontend for ClassTranscribe
https://classtranscribe.illinois.edu
Other
25 stars 27 forks source link

Todo: CTHTTPRequest - add default CORS headers? #731

Closed angrave closed 6 months ago

angrave commented 7 months ago

Should we use a version of the following as the default config for CTHTTPRequest in request.js? (At least during development when running the frontend on a different server)

const defaultconfig = {
   headers: {
     "Access-Control-Allow-Origin": "*", // or something more limited?
     "Access-Control-Allow-Methods": "GET,PUT,POST,DELETE,PATCH,OPTIONS"
   }
};

"Access-Control-Allow-Methods" is already used in several places in the frontend code.

angrave commented 6 months ago

Implemented in d7b0e50a48db31842c33f47f75afdab03cc01877