Consume arrow keys when changing playback rate

[angrave]

When changing playback rate using arrow keys, the video also jumps forwards and backwards. These events should be consumed by the control and not propagated to the player.

[mumbler6]

@angrave

Just to clarify, by the video jumping forward and backward, do you mean similar to how the left and right arrow keys skip 10 seconds back and forward? The playback rate shortcuts are on SHIFT+Up Arrow and Shift+Down Arrow, so changing the playback rate like this doesn't seem to jump the video forwards or backwards in that sense.

[angrave]

Maybe this issue description is out of date. But there's still some quirky stuff.

• Using shift versions I managed to get a displayed playback rate in the lower bar of "0.899999999" and also "x.0000...2". (I can't tell you how to reproduce these though, if I do, I'll update this issue... but it involves adding and subtracting a lot of deltas to exploit floating point error).
• Another floating point error I managed to create: After adding and subtracting I managed to see a customized rate of "1.25" in the popup and the lower bar shows "1.25" but in the vertical options in the popup has "1" ticked, not 1.25 ticked
• When the popup menu is displayed: Moving up to the customized control you can press left arrow (without the shift) to reduce the rate multiple times (as expected - you are controlling the UI element). However pressing right arrow increases the rate once but also shifts the focus to the vertical menu -so future attempts don't do anything. So you can only increment the rate once using the control, as the focus has now changed. I think right arrow event should be eaten at this point. i.e. use tab to leave the control.