classtranscribe / FrontEnd

The React + Redux Frontend for ClassTranscribe
https://classtranscribe.illinois.edu
Other
25 stars 27 forks source link

Review yarn react a11y warnings #740

Open angrave opened 7 months ago

angrave commented 7 months ago

Review the a11y warnings generated by yarn. Are these valid? If so fix them. If not, disable the warning for that sourcecode line.

yarn start | grep -B3 -i a11y (label warnings have their own separate github issue so are not included below)

src/components/CTImagePickerModal/ImagesTab.js Line 22:13: Visible, non-interactive elements with click handlers must have at least one keyboard listener jsx-a11y/click-events-have-key-events Line 22:13: Non-interactive elements should not be assigned mouse or keyboard event listeners jsx-a11y/no-noninteractive-element-interactions Line 24:15: tabIndex should only be declared on interactive elements jsx-a11y/no-noninteractive-tabindex

src/components/CTMarkdown/MarkdownEditor/index.js Line 88:7: Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element jsx-a11y/no-static-element-interactions

src/components/CTPlayer/Player/index.js Line 70:7: Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element jsx-a11y/no-static-element-interactions Line 73:9: tabIndex should only be declared on interactive elements jsx-a11y/no-noninteractive-tabindex Line 85:5: Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element jsx-a11y/no-static-element-interactions Line 88:7: tabIndex should only be declared on interactive elements jsx-a11y/no-noninteractive-tabindex

src/components/CTPlayer/Wrapper/InteractiveLayer/ControlBar/index.js Line 33:7: Visible, non-interactive elements with click handlers must have at least one keyboard listener jsx-a11y/click-events-have-key-events Line 33:7: Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element jsx-a11y/no-static-element-interactions

src/components/CTPlayer/Wrapper/NonInteractiveLayer/index.js Line 23:5: Visible, non-interactive elements with click handlers must have at least one keyboard listener jsx-a11y/click-events-have-key-events Line 23:5: Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element jsx-a11y/no-static-element-interactions

src/components/Modals/index.js Line 41:7: Visible, non-interactive elements with click handlers must have at least one keyboard listener jsx-a11y/click-events-have-key-events Line 41:7: Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element jsx-a11y/no-static-element-interactions

src/components/index.js Line 53:5: Visible, non-interactive elements with click handlers must have at least one keyboard listener jsx-a11y/click-events-have-key-events Line 53:5: Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element jsx-a11y/no-static-element-interactions

src/layout/CTNavHeader/NavHeaderMenu/MenuTrigger.js Line 45:5: Visible, non-interactive elements with click handlers must have at least one keyboard listener jsx-a11y/click-events-have-key-events

src/layout/CTNavHeader/NavHeaderSearch/index.js Line 87:5: Visible, non-interactive elements with click handlers must have at least one keyboard listener jsx-a11y/click-events-have-key-events Line 87:5: Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element jsx-a11y/no-static-element-interactions

src/layout/CTNavSidebar/index.js Line 29:7: Visible, non-interactive elements with click handlers must have at least one keyboard listener jsx-a11y/click-events-have-key-events Line 29:7: Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element jsx-a11y/no-static-element-interactions

src/screens/Asl/components/AslTable/index.js Line 221:9: Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element jsx-a11y/no-static-element-interactions Line 244:13: Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element jsx-a11y/no-static-element-interactions

src/screens/EPub/views/EditEPubStructure/ChapterList/EPubListItem.js Line 100:9: Visible, non-interactive elements with click handlers must have at least one keyboard listener jsx-a11y/click-events-have-key-events

src/screens/Watch/Components/CTPlayer/PlayerWrapper.jsx Line 24:5: Visible, non-interactive elements with click handlers must have at least one keyboard listener jsx-a11y/click-events-have-key-events Line 24:5: Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element jsx-a11y/no-static-element-interactions

src/screens/Watch/Components/ControlBar/ProgressBar/index.js Line 36:7: Visible, non-interactive elements with click handlers must have at least one keyboard listener jsx-a11y/click-events-have-key-events Line 36:7: Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element jsx-a11y/no-static-element-interactions

src/screens/Watch/Components/Menus/PlaylistsMenu/PlaylistView.jsx Line 31:13: Interactive elements should not be assigned non-interactive roles jsx-a11y/no-interactive-element-to-noninteractive-role

src/screens/Watch/Components/Modals/index.js Line 25:9: Visible, non-interactive elements with click handlers must have at least one keyboard listener jsx-a11y/click-events-have-key-events Line 25:9: Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element jsx-a11y/no-static-element-interactions

src/screens/Watch/Components/Search/Results/ResultListItems.jsx Line 32:13: Interactive elements should not be assigned non-interactive roles jsx-a11y/no-interactive-element-to-noninteractive-role Line 42:49: Dangerous property 'dangerouslySetInnerHTML' found react/no-danger

src/screens/Watch/Components/Transcriptions/CaptionLine/index.js Line 98:9: Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element jsx-a11y/no-static-element-interactions