classtranscribe / FrontEnd

The React + Redux Frontend for ClassTranscribe
https://classtranscribe.illinois.edu
Other
25 stars 27 forks source link

Add warning ignore in webpack config (Fix: #734) #817

Closed harsh183 closed 3 weeks ago

harsh183 commented 3 weeks ago

https://github.com/classtranscribe/FrontEnd/issues/734

Following the still open https://github.com/cthackers/adm-zip/issues/242, I was able to find out that the original-fs dependency is only needed for electronJS, so it's quite safe to ignore. Thanks to us being able to configure webpack as we want after the eject, I just added the ignore through the plugins.

Updating the version to the latest adm-zip (4 years of updates) didn't help, we could do this upgrade anyway, but I don't see any use just yet and we can do that in the future if needed when we have better tests for epub generation.