search

classtranscribe / FrontEnd

The React + Redux Frontend for ClassTranscribe
https://classtranscribe.illinois.edu
Other
25 stars 27 forks source link

570 lectures with two videos no way to bring back after hiding #826

Open mumbler6 opened 1 week ago

mumbler6 commented 1 week ago

Fixes #570

Adds this modal window for changing between screen modes (hiding secondary player is primary mode, unhiding is distributed): image

Adds corresponding settings in the settings menu: image

angrave commented 1 week ago

@harsh183 do you have any comments. This looks ready to merge to me. (apart from it is still a draft request)

mumbler6 commented 1 week ago

@harsh183 do you have any comments. This looks ready to merge to me. (apart from it is still a draft request)

I made it a draft request since I'm still unsure on how to write test cases, especially with the errors with redux we found last time.

harsh183 commented 1 week ago

@angrave I think this is ready to merge too! As for test cases we'll figure it out later and then do any refactoring if needed then. I'm traveling till next Tuesday so I'll be able to take a crack at test cases with redux then to figure out what's up.