search

classtranscribe / FrontEnd

The React + Redux Frontend for ClassTranscribe
https://classtranscribe.illinois.edu
Other
25 stars 27 forks source link

add .nvmrc #827

Open harsh183 opened 1 week ago

harsh183 commented 1 week ago

Instead of specifying number on the wiki or docker, we can specify a precise number there and bump as we need

angrave commented 1 week ago

That's cool. However the production build will use whatever is specified in the docker build- https://github.com/classtranscribe/FrontEnd/blob/staging/Dockerfile "FROM --platform=$BUILDPLATFORM node:18 AS frontend"

so I suggest our wiki instructions (and any comments in the nvmrc file) should explicitly reference that as the source of the authoritative version number (except when developers are exploring more modern version).

angrave commented 1 week ago

(We could change the production build to use nvm; but today I have a slight preference for choosing a docker image with prebuilt node version).

harsh183 commented 1 week ago

Yeah, my goal is for more development reasons but docker can also use this with some effort. I noticed how convenient having a node version file was in another project and I thought, huh, CT can totally use this