search

classy-giraffe / easy-arch

Script for boostrapping Arch Linux with BTRFS, snapshots and LUKS encryption (UEFI only).
https://classy-giraffe.github.io/easy-arch
Apache License 2.0
237 stars 54 forks source link

[feature]: Adding more package options to script. #13

Closed iSparsh closed 3 years ago

iSparsh commented 3 years ago

Hello there, great work! Reading through the script I had a few suggestions:-

  1. In the base installation command, I notice base-devel is missing. It already includes a bunch of stuff like sudo, gawk, gcc, automake and others. I realize that some users may not want all of the things so we should definitely keep a condition (like the kernel choices but only yes/no for this one) whether the user wants to install this package or not.
  2. Similarly, we should keep a condition for users to have a choice between their network utilities (example: NetworkManager, iwd, or skip/install later).

I would definitely like to add them myself as soon as I can, but real-life is keeping me busy atm.

classy-giraffe commented 3 years ago

I added a section where you can pick up a way to handle networking.

iSparsh commented 3 years ago

Thanks for the prompt changes! Love the script. Just had a question, would you accept a PR where base-devel gets installed (hard-coded) ? Or should I make a section where the user can choose to install the package optionally? I'm highly in favor of this package because it takes care of all dependencies to make an compile user repos, git clone and all others. Currently, nothing of that sort is being installed on the system.

iSparsh commented 3 years ago

I have made a PR regarding the base devel package so i'll close this issue