Inprovements

[i-c-u-p]

There's several changes, but the main ones are:

• Change some functions to not format/install until after the user has already answered all pre-install questions, and move microcode_detector and virt_check later in the script for the same reason
• Ability to search existing locales/keyboard layouts by entering "/" at the prompts
  • Once a locale/layout is actually entered, it's checked against all existing ones to see if it exists, and if not the function is re-ran to pick again
• When installing the locale, don't assume it's UTF-8, and uncomment it from locale.gen instead of appending it
• Move mount options to variables for neatness and ease of modification
• Put subvols in array so they can be created with a loop (and mounted if the subvol name is it's mount dir with / replaced with _ (e.g. @var_log))
• Changed functions with user input to use a different method for repeating questions after incorrect input to fix a bug where if incorrect answers are given the function's commands will run multiple times after a correct answer
• Change permissions of /root from 755 to 750 to fix "directory permissions differ" warnings during pacstrap

[classy-giraffe]

I don't mind the changes you've done but I got a few requests: 1) Could you please make sure the code pass the checks? (It's just a bash syntax checker that make sure that you're using solid techniques while writing scripts) 2) The part where you change the parameters for grub should not be touched as I use a systemd based initramfs (that's why I need "rd.") and yes despite systemd being able to find stuff on its own, I've read somewhere that specifying parameters make the boot process faster. Thank you as always! 💗

[i-c-u-p]

The part where you change the parameters for grub should not be touched

It should be fixed now, I made a mistake when trying to shorten the command using & (for &'s meaning in sed see this) that caused the line to become GRUB_CMDLINE_LINUX="<options>"". Although in the way I was trying to do it, it would've matched GRUB_CMDLINE_LINUX= with 1 quote after it instead of two so I changed it a bit more to match 2 while still being short, but if it only needs to match 1 it can be shorter: s,^GRUB_CMDLINE_LINUX=\",&rd.luks.name=$UUID=cryptroot root=$BTRFS, than the current expression (if it's cryptic, see GNU sed manual sections 4.1 & 4.3 for info): \,^GRUB_CMDLINE_LINUX=\"\",s,\",&rd.luks.name=$UUID=cryptroot root=$BTRFS,

[classy-giraffe]

I'm at school right now, if you can assure me the script works flawlessly, I'll be accepting the PR. Or if you prefer, I can wait till i get home, and test it myself. As you wish, let me know! 😝

[i-c-u-p]

I'm at school right now, if you can assure me the script works flawlessly, I'll be accepting the PR. Or if you prefer, I can wait till i get home, and test it myself. As you wish, let me know! stuck_out_tongue_closed_eyes

It'd be better for you to test it at home as I made a lot of changes (some incorrectly at first which had to be fixed later, as you can tell from the commit titles & messages).

[classy-giraffe]

Not a sed expert can we try to fix this cause the Github Actions failing is bothering me 😭

[i-c-u-p]

Not a sed expert can we try to fix this cause the Github Actions failing is bothering me sob

Bash parameter expansion doesn't seem to support backreferences so I don't know how to remove sed from that one.