search

classy-python / ccbv

A documentation tool for getting your head around Django's class based views.
https://ccbv.co.uk/
BSD 2-Clause "Simplified" License
521 stars 68 forks source link

inspect the Message view (SuccessMessageMixin) as well fixing #206 #207

Closed KommuSoft closed 1 year ago

KommuSoft commented 1 year ago

Fixing #206

meshy commented 1 year ago

Hi @KommuSoft, thanks for reporting #206, and taking the time to try to fix it.

Unfortunately, I am going to close it for now, because it's a duplicate of #121. I will pin the original ticket to make it more obvious.

I will also have to reject your PR for the moment. There are a couple of reasons for this:

  1. We are unable to address this issue before fixing the navigation (as mentioned in #121).
  2. Any fix for this would need to modify the fixtures, so that the missing mixin is available in old versions.

Thanks again for the submission.