classyllama / ClassyLlama_AvaTax

This extension has been deprecated in favor of https://github.com/avadev/Avalara-AvaTax-for-Magento2
Open Software License 3.0
23 stars 15 forks source link

Add support for TaxIncluded API flag #127

Closed erikhansen closed 5 years ago

erikhansen commented 6 years ago
  1. Setting the STORES > Settings > Configuration > SALES > Tax > Calculation Settings > Catalog Prices = Including Tax will cause the AvaTax extension to set ‘TaxIncluded = true’ for the products in the API call
  2. Setting the STORES > Settings > Configuration > SALES > Tax > Calculation Settings > Shipping Prices = Including Tax will cause the AvaTax extension to set ‘TaxIncluded = true’ for shipping in the API call
  3. When the AvaTax extension assigns the values to the product, it will also assign the appropriate pre and post tax values for the items on the order.

These changes are only to affect how the AvaTax extension communicates with the Avalara system for tax calculation in order to accommodate your desire to set the products' price attribute to include sales tax in the set value.

rsisco commented 6 years ago

There are a few things items worth noting when using this functionality:

  1. An individual product's subtotal may display inaccurately in the cart: As noted in the screenshot, this is the result of rounding when the pretax price is being calculated from the provided post-tax price and tax rate. This same behavior is encountered when using native Magento tax calculation in this scenario and is not related specifically to the AvaTax extension.
  2. When prices include tax, applied discount amounts are considered to include tax and the subtotal includes the full discount amount: The discount behavior should account for most use cases, since a discount will typically need to reduce the taxable amount of the order (exceptions being reimbursable discounts like manufacturer's coupons where the merchant ultimately still receives the full order value). The subtotal behavior still results in a correct order total, since the tax calculation doesn't use the visible subtotal amount and instead calculates it from scratch.
  3. When prices exclude tax, applied discount amounts are considered to exclude tax:
erikhansen commented 6 years ago

@rsisco What's the status of this functionality? Did it ever get released?

rsisco commented 6 years ago

@erikhansen This is still pending verification by the merchant.

erikhansen commented 5 years ago

@Avalara - See the latest comment on the PR linked to above for the details on the status of this issue.

erikhansen commented 5 years ago

This issue will be addressed once the new maintainers of this extension merge in the code from the #228 PR. Closing this ticket since all future development will be done in this repo: https://github.com/avadev/Avalara-AvaTax-for-Magento2