search

classyllama / ClassyLlama_AvaTax

This extension has been deprecated in favor of https://github.com/avadev/Avalara-AvaTax-for-Magento2
Open Software License 3.0
23 stars 15 forks source link

Module not compatible with Magento 2.3 #137

Closed dverkade closed 5 years ago

dverkade commented 6 years ago

With the upcoming release of Magento this module should be compatible with version 2.3.

Preconditions

  1. Magento 2.3.0 Alpha

Steps to reproduce

  1. Install the Avatax module with composer.

Expected result

  1. Module should be installed

Actual result

  1. Module can not be installed due to version constraints, see screenshot: image
rsisco commented 6 years ago

@dverkade - We haven't yet tested the extension's compatibility with 2.3 so we haven't updated the composer dependencies to allow its installation yet.

dverkade commented 6 years ago

@rsisco check the PR's which I have submitted fixes to make the module compatible with Magento 2.3.

michaeljdietz commented 5 years ago

Any word when we can expect a version compatible with 2.3 now that 2.3.0 has been officially released?

rsisco commented 5 years ago

@dverkade / @michaeljdietz - I have opened an internal ticket to update the extension and test its compatibility with Magento 2.3.

lyoshigw commented 5 years ago

Has there been any updates? We want to update to Magento 2 v2.3 on Enterprise, but are concerned about its compatibility with Avatax

vadim4err commented 5 years ago

also we have the same issue. waiting for ClassyLlama response

rsisco commented 5 years ago

We are in the final steps of testing and revising the extension for 2.3 compatibility and expect to push a new release in the next few days.

rsisco commented 5 years ago

Code revisions addressing this issue have been merged into the develop branch and will be included in the next release.

dverkade commented 5 years ago

@rsisco what I find weird is that my PR is not merged, instead you have decided to copy my changes and commit them again on a different branch. Would be nicer to recognise the work that has already been done voluntarily and give credits for it.

rsisco commented 5 years ago

@dverkade - I apologize for not being clear. We needed to modify your work slightly to maintain backwards compatibility with 2.1 and 2.2 and I inadvertently took an approach that didn't retain links to your original commits, but will give attribution to you in the changelog when the new version is released. Thank you for your contribution.

rsisco commented 5 years ago

This issue has been addressed in release 1.5.0.