classyllama / ClassyLlama_AvaTax

This extension has been deprecated in favor of https://github.com/avadev/Avalara-AvaTax-for-Magento2
Open Software License 3.0
23 stars 15 forks source link

Feature/421 43 refund to store credit #55

Closed rsisco closed 7 years ago

rsisco commented 7 years ago
mttjohnson commented 7 years ago

We should review the use of extension attributes for Magento\Sales\Api\Data\CreditmemoInterface in etc/extension_attributes.xml

I'm wondering how this works when used with a SearchResult on a list of multiple CreditMemo results. I'm not sure we have an existing use case for this, but it is something to be aware of at least.

There is some support for extension attributes that utilize a reference table (reference_table, reference_field, join_on_field) http://devdocs.magento.com/guides/v2.0/extension-dev-guide/attributes.html.

mttjohnson commented 7 years ago

You will probably also want to resolve branch conflicts before your final test.