Accept version strings with and without a 'v' prefix

clastix / cluster-api-control-plane-provider-kamaji

The Kamaji Control Plane provider implementation of the Cluster Management API

Apache License 2.0

80 stars 29 forks source link

Accept version strings with and without a 'v' prefix #109

Closed chess-knight closed 4 months ago

chess-knight commented 4 months ago

When using ClusterClasses, Version is propagated from cluster.Spec.Topology into the kamajicontrolplane.Spec with a "v" prefix and then Kamaji complains about the wrong version format. See CAPI defaulting webhook https://github.com/kubernetes-sigs/cluster-api/blob/main/internal/webhooks/cluster.go#L100

chess-knight commented 4 months ago

Thanks for the contribution, highly appreciated!

Versioning of the Kubernetes cluster always puzzled me, especially with Cluster API: what's the correct way, in the end, naked (with no v prefix) or the opposite? 🤔

IMO the opposite is the correct way, i.e. v1.30.1