fix: patchCluster not working on vsphere

clastix / cluster-api-control-plane-provider-kamaji

The Kamaji Control Plane provider implementation of the Cluster Management API

Apache License 2.0

80 stars 29 forks source link

fix: patchCluster not working on vsphere #91

Closed hexchen closed 6 months ago

hexchen commented 6 months ago

Patching the controlPlaneEndpoint in the VSphere cluster was broken due to a bad comparison (Is instead of As, so comparing the error contents instead of the error type). This PR fixes that.

I also fixed a typo in the error message itself.

prometherion commented 6 months ago

Thanks for this, @hexchen, definitely my bad.

Once the minor linting/styling issue has been fixed we can quickly release this as v0.7.1: let me know if it's ok.

hexchen commented 6 months ago

Go for it, a quick release would be nice.