search

clastix / cluster-api-control-plane-provider-kamaji

The Kamaji Control Plane provider implementation of the Cluster Management API
Apache License 2.0
74 stars 25 forks source link

Update go libs #93

Closed kvaps closed 4 months ago

kvaps commented 4 months ago

required for https://github.com/clastix/cluster-api-control-plane-provider-kamaji/pull/78

go 1.20 --> 1.22
kamaji v0.4.0 --> v0.5.0
cluster-api v1.4.0-beta.2.0 --> v1.6.4
kubernetes v0.29.0 --> v0.30.0
controller-gen v0.12.0 --> v0.14.0
prometherion commented 4 months ago

I think we need to update also the Go version of the underlying GH actions.

prometherion commented 4 months ago

I know the problem with controller-gen and Go 1.22, we just need to bump it to v0.14.0

prometherion commented 4 months ago

This change is a bit intrusive 😄

Please, let's generate manifests with make release and let's remove the gocognit ignore, you can double check with make lint.

kvaps commented 4 months ago

Sure fixed

kvaps commented 4 months ago

I had old controller-gen at my PC, now diff should be fixed

prometherion commented 4 months ago

make release is still required, I guess

kvaps commented 4 months ago

aha, you're right. rebased