fix(capi): secrets type must be cluster.x-k8s.io/secret

clastix / cluster-api-control-plane-provider-kamaji

The Kamaji Control Plane provider implementation of the Cluster Management API

Apache License 2.0

80 stars 29 forks source link

fix(capi): secrets type must be cluster.x-k8s.io/secret #96

Closed prometherion closed 6 months ago

prometherion commented 6 months ago

Closes #92.

@hexchen may I ask you for a review on this? Since it was a straightforward one I tried to implement it on my own, hope you don't mind.

prometherion commented 6 months ago

Unfortunately, type is immutable, if someone's facing issues (like you) the secrets must be deleted and created back by running v0.8.0

Seems reasonable to me, and deleting secrets is not a big problem since the source of truth are the Kamaji ones, so it's just a matter of replication.