search

clastix / kamaji

Kamaji is the Hosted Control Plane Manager for Kubernetes.
https://kamaji.clastix.io
Apache License 2.0
992 stars 90 forks source link

Datastore migration job name exceeds max length #390

Closed sn4psh0t closed 9 months ago

sn4psh0t commented 9 months ago

When migrating a TenantControlPlane between Two datastores a migrate job Is launched. Job's name Is formatted as migrate-<namespace>-<tcp-name>. The resulted string May exceed the 64 char max length of the field.

In this case the kamaji controller output shows:

...error: unable to launch migrate job: Job.batch "migrate-<namespace>-<tcp-name>" Is invalid: spec.template.labels: Invalid value "migrate-<namespace>-<tcp-name>" must be no more than 63 characters
prometherion commented 9 months ago

I'd say we could use the TenantControlPlane UID here, adding the namespace and the name as label to simplify the retrieval of the Job and related pod.

sn4psh0t commented 9 months ago

Yes, lgtm!