search

clastix / kamaji

Kamaji is the Hosted Control Plane Manager for Kubernetes.
https://kamaji.clastix.io
Apache License 2.0
992 stars 90 forks source link

Allow overriding konnectivity parameters #411

Closed jwitko closed 6 months ago

jwitko commented 7 months ago

Fixes #410

This will allow us to override konnectivity hard-coded defaults using the existing extraArgs parameter.

netlify[bot] commented 7 months ago

Deploy Preview for kamaji-documentation ready!

Name Link
Latest commit 9ab29fcac1c3af00486ef3c83e823a22f71538a7
Latest deploy log https://app.netlify.com/sites/kamaji-documentation/deploys/65de150191ea390008c0074f
Deploy Preview https://deploy-preview-411--kamaji-documentation.netlify.app/reference/api
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jwitko commented 7 months ago

May I ask you to follow the semantic commit message convention, please?

will do!

prometherion commented 7 months ago

If the suite is green I can reword the commit, no worries.

jwitko commented 7 months ago

If the suite is green I can reword the commit, no worries.

Found some issues locally. Will come back with reworded commit and working tests.

jwitko commented 7 months ago

@prometherion OK did a bit of reworking. Now allowing the address to be set via TenantControlPlane.spec.addons.konnectivity.server.address but also still overriding agent arguments via extraArgs.

Open to any comments/concerns/questions.

jwitko commented 6 months ago

After realizing the CRDs are generated from #414 I modified this PR to also generate the CRD changes from the code comments.

jwitko commented 6 months ago

Please, may I ask you to commit the changes generated by make yaml-installation-file?

Yes of course, it's done now.