search

clatlan / cdiutils

A python package to help Coherent Diffraction Imaging (CDI) practitioners in their analysis.
MIT License
12 stars 7 forks source link

Redundant variables pixel size #56

Open kyolson opened 5 months ago

kyolson commented 5 months ago

In the "det_calib_parameters" there is the pixel width, and there is also "pixel_size_detector" for the pynx parameters. I often forget to change the "pixel_size_detector" and only change the size in the "det_calib_parameters". The pynx parameter should simply be set by looking at the "det_calib_parameters". Also pynx can not handle a non-square pixel, but I don't think this is an issue since I haven't seen any detectors with rectangular (hexagonal??) pixels.

clatlan commented 5 months ago

I thought I dealt with this in the last version of the notebook? Anyway, I ll leave this open cause I am working on new notebooks, and I probably need to lighten the parameter part and take care of this in the code itself.