search

claudegel / sinope-130

Neviweb130 custom component for Home Assistant to manage devices connected via a GT130 and wifi devices from Sinopé
GNU General Public License v3.0
63 stars 13 forks source link

The temperatureFormat in service set_temperature_format expects "celcius" instead of "celsius" #188

Closed visto9259 closed 8 months ago

visto9259 commented 8 months ago

The temperatureFormat argument in service set_temperature_formatchecks for celcius instead of celsius.

Then it sends celcius to the device which does not work.

The bug is here in climate.py:

SET_TEMPERATURE_FORMAT_SCHEMA = vol.Schema( { vol.Required(ATTR_ENTITY_ID): cv.entity_id, vol.Required(ATTR_TEMP): vol.In(["celcius", "fahrenheit"]), } )

This is a small fix. Let me fork and do a PR to fix it.

claudegel commented 8 months ago

Nice catch. We need to change climate.py. No need for a PR I'll fix it now. Thank you for finding this typo

claudegel commented 8 months ago

I've created a new branch typo to fix this. I'll do a release this week

visto9259 commented 8 months ago

Good. I did a quick patch on my installation by modifying the code directly in my HASS installation and it worked.

claudegel commented 8 months ago

I've push the release 2.4.6. Thanks for reporting this.