search

claudegel / sinope-130

Neviweb130 custom component for Home Assistant to manage devices connected via a GT130 and wifi devices from Sinopé
GNU General Public License v3.0
62 stars 13 forks source link

implements HVACMode(s): heat, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature #214

Closed karco closed 5 months ago

karco commented 5 months ago

Hi, I have this message in my logs.

Home Assistant 2024.1.6 & 2024.2.0

Logger: homeassistant.components.climate Source: components/climate/init.py:354 Integration: Climate (documentation, issues) First occurred: 13:39:15 (8 occurrences) Last logged: 13:39:15

Entity None (<class 'custom_components.neviweb130.climate.Neviweb130G2Thermostat'>) implements HVACMode(s): heat, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'neviweb130' custom integration Entity None (<class 'custom_components.neviweb130.climate.Neviweb130FloorThermostat'>) implements HVACMode(s): heat, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'neviweb130' custom integration

karco commented 5 months ago

Detail logs

2024-02-08 14:08:18.660 WARNING (MainThread) [homeassistant.components.climate] Entity None (<class 'custom_components.neviweb130.climate.Neviweb130G2Thermostat'>) implements HVACMode(s): heat, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'neviweb130' custom integration
2024-02-08 14:08:18.663 WARNING (MainThread) [homeassistant.components.climate] Entity None (<class 'custom_components.neviweb130.climate.Neviweb130G2Thermostat'>) implements HVACMode(s): heat, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'neviweb130' custom integration
2024-02-08 14:08:18.663 WARNING (MainThread) [homeassistant.components.climate] Entity None (<class 'custom_components.neviweb130.climate.Neviweb130G2Thermostat'>) implements HVACMode(s): heat, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'neviweb130' custom integration
2024-02-08 14:08:18.664 WARNING (MainThread) [homeassistant.components.climate] Entity None (<class 'custom_components.neviweb130.climate.Neviweb130FloorThermostat'>) implements HVACMode(s): heat, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'neviweb130' custom integration
2024-02-08 14:08:18.664 WARNING (MainThread) [homeassistant.components.climate] Entity None (<class 'custom_components.neviweb130.climate.Neviweb130G2Thermostat'>) implements HVACMode(s): heat, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'neviweb130' custom integration
2024-02-08 14:08:18.664 WARNING (MainThread) [homeassistant.components.climate] Entity None (<class 'custom_components.neviweb130.climate.Neviweb130G2Thermostat'>) implements HVACMode(s): heat, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'neviweb130' custom integration
2024-02-08 14:08:18.664 WARNING (MainThread) [homeassistant.components.climate] Entity None (<class 'custom_components.neviweb130.climate.Neviweb130G2Thermostat'>) implements HVACMode(s): heat, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'neviweb130' custom integration
2024-02-08 14:08:18.664 WARNING (MainThread) [homeassistant.components.climate] Entity None (<class 'custom_components.neviweb130.climate.Neviweb130G2Thermostat'>) implements HVACMode(s): heat, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'neviweb130' custom integration
claudegel commented 5 months ago

yes I got the same in my log with the last HA update. As the thermostat implement HVACMode.heat and HVACMode.off it need to implement method trun_on and turn_off same as for light. I'll add those method. turn_off will set HVACMode.off and turn_on will set HVACMode.heat as there are no HVACMode.on I'll test on my side and make a new release once it is working. I have floor and G2 thermostats to test. Thanks for reporting this

claudegel commented 5 months ago

I have a fix on branch https://github.com/claudegel/sinope-130/tree/turn_on/off/custom_components/neviweb130 please test. on my side no more error

karco commented 5 months ago

I confirm, no more warning. I will be able to test with HACS when you are ready.

Thank you very much @claudegel

claudegel commented 5 months ago

I just push a new release