search

claudehohl / Stikked

An advanced and beautiful pastebin written in PHP
991 stars 219 forks source link

Remove PHP handler specification from .htaccess #503

Closed groovenectar closed 5 years ago

groovenectar commented 6 years ago

Let the server administrator decide the PHP configuration. This can cause an issue where the browser downloads instead of displays, even in very common shared hosting configurations.

glensc commented 5 years ago

in production, you should ignore .htaccess for performance reasons: AllowOverride None

groovenectar commented 5 years ago

in production, you should ignore .htaccess for performance reasons: AllowOverride None

That's fine, although a lot of shared hosts have it enabled in their environment by default.

If someone is running PHP7, that line would probably break the application as well.

To be safe, might as well not have it in there I think

glensc commented 5 years ago

to correct: I'm not against the change proposed here! I totally agree that what is committed too specific to a certain setup.

claudehohl commented 5 years ago

You're right. I had it there because something broke the spamadmin-login. https://github.com/claudehohl/Stikked/commit/6d00897ed11be1454c04673c87cb1672bfd29e61

Removed it now and it still works... Thanks for the pullrequest.

claudehohl commented 5 years ago

Hmm, I accidentally hit close and comment instead of comment, and now I can't reopen the PR because the repository of this PR has been deleted. ¯_(ツ)_/¯

claudehohl commented 5 years ago

https://github.com/claudehohl/Stikked/commit/e095fd0d156b5f2d82518831355dd9cbf978f09c