When $config['url_shortening_use'] is set to off, it should not be displayed at all

TehPeGaSuS commented 2 years ago

If you set $config['url_shortening_use'] to false, the Shorturl var(?) is still shown with a value of false and clicking on the value leads us to a 404 Page not found.

It should behave like $config['qr_enabled'] which doesn't display any value at all when set to false.

Here is an example of the above behavior.

Cheers!

krayon commented 2 years ago

@PeGaSuS-Coder : Could you share your config (making sure you clear out your private credentials etc). I personally couldn't replicate this but it seems likely that it could be the theme you're using.

TehPeGaSuS commented 2 years ago

@krayon, my actual config can be seen here.

I can't figure out what I might be doing wrong.

Cheers

krayon commented 2 years ago

@PeGaSuS-Coder - I'm a bit confused too. Initially I thought it could have been one of the changes I'd made on my fork ( https://github.com/krayon/stikked/tree/main ) but I just tested with the latest here and your config (for the most part) and can't replicate the issue :confused:

The only thing I could suggest is trying the literal value false for $config['url_shortening_use'] instead of 'off'. It shouldn't make a difference really since it seems to still look for a API with that name but worth a try if you just want to "fix the issue". It could even be a specific PHP configuration that's causing booleans to be treated as strings (though I don't know of anything like that that exists).

The code here ( htdocs/application/models/Pastes.php, line 155 onwards ) shows:

if ($url_shortening_api !== false) {

This checks it is not a literal boolean false

    if (in_array($url_shortening_api, $API_DB, true)) {

This checks for a defined URL Shortening API with that name (off in your case) which isn't part of that array, so this block should never get any further.

    } else {
        $shorturl = false;
    }

Finally, it should set $shorturl to false (which later should avoid rendering). We can see in your case, the string false is actually being rendered which is a bit weird.

} else {

    //  Backward compatibility - Falling back to legacy mode
    $config_yourls_url = $this->config->item('yourls_url');

    if ($config_yourls_url) {
...
    } else {

        //use gdgw
        $url = urlencode($url);
        $config_gwgd_url = $this->config->item('gwgd_url');
...

A little strange (as the comment suggests though, probably just for backwards compatibility), if url_shortening_api is set to literally false, then it still looks for yourls and gdgw configurations so if you are trying false, ensure you don't have yourls or gdgw settings configured.

Later, when it comes time to render, the theme you're using "bootstrap" ( htdocs/themes/bootstrap/views/view/view.php, line 40 to 42 ) , checks for not empty ( !empty() ) before rendering:

<?php if(!empty($snipurl)){?>
    <div class="detail"><div class="item"><?php echo lang('paste_shorturl');?> </div><a href="<?php echo $snipurl; ?>"><?php echo htmlspecialchars($snipurl) ?></a></div>
<?php }?>

Note that php empty() actually interprets a boolean false as empty.

Thus, the only way I think that you could be getting what you're seeing is if something is turning your false (boolean) into 'false' (string).

Sidenote: I notice the config you shared's comments are missing URLs and your $config['base_url'] is missing a close-single-quote ('). I'm assuming this isn't related and is just because you've used a sanitiser that strips URLs indiscriminately to end-of-line.

TehPeGaSuS commented 2 years ago

the $config['base_url'] is properly set to https://pastebin.pixelizez.com/ (I don't know how I removed it from the example). Other than that I don't know what others URLs might be missing.

The issue happens when you create a paste and don't check the Create Shorturl option, even if you have bitly (as example) set to shorten URLs.

I've also tried with the values of false, off and none on the $config['url_shortening_use'] option and all lead to the same issue.

Cheers

TehPeGaSuS commented 2 years ago

Small heads up:

Apparently the issue happens when using PostgreSQL as database.

Using sqlite seems to work as expected.

Any ideas?

Feel free to see it live on my instance

Current `stikked.php` config

<?php if (!defined('BASEPATH')) {
    exit('No direct script access allowed');
}

/**
 * Site Name
 *
 * The name of your site
 *
 */
$config['site_name'] = 'øbin - Pastebin';

/**
 * Base URL
 *
 * Set the base URL of Stikked. WITH trailing slash!
 *
 */
$config['base_url'] = 'https://0bin.xyz/';

/**
 * Database connection
 *
 * Credentials for your database
 * The database structure will be created automatically
 *
 */
$config['db_hostname'] = '127.0.0.1';
$config['db_database'] = 'db_name';
$config['db_username'] = 'db_user';
$config['db_password'] = 'db_password';

// If you are using sqlite:
// uncomment the configuration lines below.
//$config['db_database'] = 'db/stikked'; // you need to create a directory "db" and give the webserver write access. sqlite needs a writable folder to work properly!
//$config['db_driver'] = 'sqlite';
$config['db_driver'] = 'postgre';

/**
 * Table prefix
 * Generate table prefix for stikked db, commonly used if the webhoster only has one db.
 * Use underscore as suffix to easily see the tables.
 * example: $config['db_prefix'] = 'stikked_';
 * use $config['db_prefix'] = ''; if you don't want to use table prefix.
 */
$config['db_prefix'] = '';

/**
 * Theme
 *
 * Which theme to use
 * Folder name in htdocs/themes/
 * Currently: default, bootstrap, gabdark, gabdark3, geocities, snowkat, stikkedizr, cleanwhite, i386
 *
 */
$config['theme'] = 'stikkedizr';

/**
 * Display QR code
 *
 * Whether or not to display the QR code
 *
 */
$config['qr_enabled'] = false;

/**
 * JavaScript-Editor
 *
 * Which editor to use
 * CodeMirror, ACE or none
 *
 * none:        ~130kb JS
 * CodeMirror:  ~300kb JS
 * ACE:         >800kb JS
 *
 */
$config['js_editor'] = 'ace'; // codemirror, ace, ''

/**
 * Language
 *
 * Which language to use
 * Translate Stikked to your own language, see htdocs/application/language files
 * Currently: english, german, swissgerman, spanish, norwegian, danish, portuguese, turkish, french, japanese, polish, russian, chinese-simplified, chinese-traditional, indonesia
 *
 */
$config['language'] = 'english';

/**
 * Combine JS & CSS files (recommended)
 *
 * htdocs/static/asset/ folder must be writeable
 *
 */
$config['combine_assets'] = true;

/**
 * Content expiration
 *
 * Sets the "Expires:"-header to make use of browser-caching
 * Format: http://php.net/manual/en/function.strtotime.php
 * Examples: '+10 seconds', '+1 year', '-1 week'
 *
 */
$config['content_expiration'] = '-1 week';

/**
 * Key for Cron
 *
 * The password required to run the cron job */
// Example cron: */5 * * * * curl --silent http://yoursite.com/cron/[key]
//
//
$config['cron_key'] = 'stikked';

/**
 * url shortener config
 *
 * url_shortening_use:
 *    - Enables specific url shortening engine or disables them all
 *    - Valid values:
 *           @string yourls
 *           @string gwgd
 *           @string googl
 *           @string bitly
 *           @string polr
 *           @string random - Randomly chose any of upper API-s !WARNING! May be slow! For maximum performanse, it's recommended to either set all API keys or use random_url_engines to list working engines.
 *           @string none - same as off
 *
 * random_url_engines:
 *    - This variable sets list of APIs to be considered for usage if url_shortening_use is set to 'random'
 *      To consider all API-s, either leave it empty (as empty array or string) or type all apis available (yourls,gwgd,googl,bitly)
 *      be aware that considering all the APIs is not recommended because program will test them all, and that affects speed.
 *      This will greatly improve performance of 'random' mode if listed are only valid, filled APIs.
 *      Accepted inputs:
 *           @array array('use this', 'and this', 'and this of course')
 *           @string 'use this,and this,and this of course'
 *      - If input is @string it must be comma delimited, otherwise will be ignored.
 *      - Script will accept minimum of 2 APIs, ignored otherwise
 *      - Only alphanumeric characters and "." are allowed. Everything else is filtered out.
 *
 * -------------------------------------------------------------------------------------------------------------
 * yourls_url: Your own instance of yourls URL-shortener (Download: http://yourls.org/)
 * Example: http://example.com/yourls/
 *
 * yourls_signature: Your signature, used to authenticate API requests.
 * You can find your signature under http://your-yourls-installation.com/admin/tools.php
 *
 * gwgd_url: Your own instance of the gw.gd URL-shortener (Download: https://github.com/neofutur/gwgd)
 * Default: http://gw.gd/
 *
 * googl_url_api: URL shortening service provided by Google Inc. (API: http://code.google.com/apis/console/)
 * Usage: Your API key
 *
 * bitly_url_api: Famous URL shortening service (API: http://dev.bitly.com/get_started.html)
 * Usage: Your API key
 *
 * polr_url: Your own instance of polr URL-shortener (Download: https://github.com/cydrobolt/polr)
 * polr_api: Your polr api key
 *
 **/
$config['url_shortening_use'] = 'bitly';
$config['random_url_engines'] = 'googl,bitly'; // Used only in random mode, read comment above for more info

// Yourls
$config['yourls_url'] = '';
$config['yourls_signature'] = '';

// gwgd_url
$config['gwgd_url'] = '';
$config['shorturl_selected'] = false;

// goo.gl API key
$config['googl_url_api'] = '';

// Bit.ly API key
$config['bitly_url_api'] = 'bitly_api_key';

// polr
$config['polr_url'] = '';
$config['polr_api'] = '';

/**
 * Credentials for the backup URL
 *
 * Basic auth user & pass for the backup URL, accessible via http://yoursite.com/backup
 *
 **/
$config['backup_user'] = 'user';
$config['backup_pass'] = 'pass';

/**
 * Pastes Per Page
 *
 * Number of pastes per page, on the recent pastes listings.
 *
 **/
$config['per_page'] = 15;

/**
 * API key
 *
 * Require a key to interact with the API.
 * Append to all API requests: ?apikey=[yourkey]
 *
 **/
$config['apikey'] = '';

/**
 * Soft API
 *
 * When set to true, allow interaction:
 *   without apikey: badword-check applies
 *   with apikey: badwords are ignored
 *
 * This is useful to maintain a restrictive blocklist
 * for spammers and bypass it using the apikey.
 *
 **/
$config['soft_api'] = false;

/**
 * Anti spam
 *
 * private_only: No recent pastes will be displayed.
 * enable_captcha: Users must enter a captcha to post.
 * recaptcha_publickey & recaptcha_privatekey: If filled, reCaptcha will be used (get a key from https://www.google.com/recaptcha/admin/create)
 * disable_api: Don't allow pasting via API (because we can't use a captcha there...)
 * disable_keep_forever: Don't allow pasting without expiration
 * blocked_words: Comma separated list, e.g. '.es.tl, mycraft.com, yourbadword'
 * disable_shorturl: "Create Shorturl" option will be disabled
 * disallow_search_engines: displays a robots.txt that forbids indexing
 *
 **/
$config['private_only'] = false;
$config['enable_captcha'] = true;
$config['recaptcha_publickey'] = 'pub_key';
$config['recaptcha_privatekey'] = 'priv_key';
$config['disable_api'] = true;
$config['disable_keep_forever'] = true;
$config['blocked_words'] = '';
$config['disable_shorturl'] = true;
$config['disallow_search_engines'] = false;

//spamadmin: accessible via /spamadmin (only active when user + pass is set)
$config['spamadmin_user'] = 'user';
$config['spamadmin_pass'] = 'pass';

/**
 * Default paste expiration time (minutes)
 *
 * Possible values:
 *  burn (burn on reading)
 *  5 (5 minutes)
 *  60 (1 hour)
 *  1440 (1 day)
 *  10080 (1 week)
 *  40320 (1 month)
 *  483840 (1 year)
 *  0 (keep forever)
 **/
$config['default_expiration'] = 10080;

/**
 * Default language
 *
 * Preselected language. See application/config/geshi_languages.php for valid values (array keys)
 *
 **/
$config['default_language'] = 'text';

/**
 * Name for anonymous poster
 *
 * What name is to be set for anonymous posters
 * DO NOT SET BLANK
 * Set to random for a random paste to be generated
 * NOTE: if changed only pastes from then on will be updated.
 *
 **/
$config['unknown_poster'] = 'random';

/**
 * Name for untitled pastes
 *
 * What name is to be set for untitled pastes.
 * DO NOT SET BLANK
 * NOTE: if changed only pastes from then on will be updated.
 **/
//$config['unknown_title'] = 'Untitled';
//$salla = substr(md5(rand()), 0, 16);
$salla = substr(str_shuffle("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"), 0, 12);
$config['unknown_title'] = ''.$salla.'';

/**
 * To require LDAP authentication or not.
 *
 * Weather to require LDAP authenticaiton or not.
 * Set to either 'true' to require authentication or 'false' not to.
 * NOTE: if changed, set LDAP settings in auth_ldap.php
 **/
$config['require_auth'] = false;

/**
 * Override the displayed URL
 *
 * Display this URL in a paste's detail view instead of the main URL - e.g. if you use mod_rewrite
 * Variable $id: the paste_id
 * Example: 'http://example.com/$id'
 *
 **/
$config['displayurl_override'] = '';

/**
 *
 *
 *  Words used for when unknown_poster is set to random
 *
 *
 **/
$config['nouns'] = array('Hornbill', 'Elephant', 'Bison', 'Lion', 'Camel', 'Sheep',
    'Monkey', 'Prairie Dog', 'Plover', 'Tapir', 'Capybara', 'Cheetah', 'Flamingo', 'Peccary', 'Eider', 'Porcupine', 'Pelican', 'Dove', 'Crane', 'Tortoise', 'Agouti',
    'Tamarin', 'Pheasant', 'Owl', 'Gibbon', 'Goose', 'Baboon', 'Hamerkop', 'Zebra',
    'Macaw', 'Gibbon', 'Madrill', 'Wolf', 'Stork', 'Armadillo', 'Ostrich', 'Marmoset',
    'Lizard', 'Panda', 'Giraffe', 'Cassowary', 'Kangaroo', 'Gorilla', 'Pheasant',
    'Finch', 'Duck', 'Matamata', 'Teal', 'Macaque', 'Goat', 'Lechwe', 'Ibis', 'Parrot',
    'Parakeet', 'Bongo', 'Pudu', 'Echidna', 'Lemur', 'Bat', 'Curlew', 'Terrapin',
    'Peafowl', 'Duck', 'Owl', 'Parakeet', 'Meerkat', 'Tern', 'Wigeon', 'Pintail',
    'Meerkat', 'Motmot', 'Motmot', 'Shama', 'Dormouse', 'Horse', 'Rhinoceros', 'Sloth',
    'Mousedeer', 'Treeshrew', 'Bushbaby', 'Guinea Pig', 'Agouti', 'Water Vole', 'Hog',
    'Pig', 'Anoa', 'Octupus', 'Butterfly', 'Cat', 'Kitten', 'Coyote', 'Crocodile',
    'Cockroach', 'Crow', 'Bird', 'Dolphin', 'Earthworm', 'Frog', 'Hamster', 'Hedgehog',
    'Hog', 'Human', 'Hummingbird', 'Iguana', 'Leech', 'Leopard', ' Marten',
    'Mockingbird', 'Mockingjay', 'Mosquito', 'Moth', 'Partdridge', 'Bee', 'Penguin');

$config['adjectives'] = array('Ample', 'Mature', 'Bulky', 'Burly', 'Capacious',
    'Colossal', 'Commodious', 'Thundering', 'Mammoth', 'Mungo', 'Voluminous',
    'Walloping', 'Tiny', 'Baby', 'Bitty', 'Diminutive', 'Little', 'Paltry', 'Scanty',
    'Trivial', 'Scribby', 'Blush', 'Tinct', 'Colorant', 'Aqua', 'Beige', 'Bistre',
    'Buff', 'Bistre', 'Chartreuse', 'Chocolate', 'Cobalt', 'Coral', 'Cream', 'Crimson',
    'Denim', 'Emerald', 'Gray', 'Gamboge', 'Ivory', 'Mustard', 'Silly', 'Perl',
    'Whipped', 'Violet', 'Harmless', 'Gentle', 'Innocent', 'Reliable', 'Unreliable',
    'Soft', 'Toxic', 'Anorexic', 'Beefy', 'Sexy', 'Morose', 'Rude', 'Ungracious',
    'Abrupt', 'Gracious', 'Queen', 'Cute', 'Edgy', 'Insensitive', 'Round', 'Sharp',
    'Gruff', 'Subtle', 'Crippled', 'Eratic', 'Social', 'Jittery', 'Sole', 'Unique',
    'Botched', 'Tacky', 'Sludgy', 'Stained', 'Wet', 'Soiled', 'Big', 'Small', 'Sloppy',
    'Smelly', 'Funky', 'Putrid', 'Melodic', 'Corrupt', 'Lousy', 'Fiery', 'Red',
    'Sweet', 'Hot', 'Scorching', 'Sweltering', 'Torrid', 'Obese', 'Speedy', 'Flying',
    'Idiotic', 'Chunky', 'Forensic');

/**
 *
 *
 *  Words used for expiring pastes
 *
 *
 **/
$config['expires'] = array('expire', 'perish', 'go to its last resting place',
    'go to meet its maker', 'cross the great divide', 'slip away', 'give up the ghost',
    'kick the bucket', 'croak', 'bite the big one', 'check out', 'buy the farm',
    'join the choir invisible', 'shuffle off the mortal coil', 'hop the perch',
    'run down the curtain', 'die', 'self destruct', 'explode');

claudehohl / Stikked