Swiss cross background & option to skip output file name check

claudep / swiss-qr-bill

A Python library to generate Swiss QR-bill payment slips

MIT License

97 stars 39 forks source link

Swiss cross background & option to skip output file name check #47

Closed ChrisBuergi closed 3 years ago

ChrisBuergi commented 3 years ago

QRBill: Set the fill color of the Swiss cross background explicitly
CLI: Option to skip output file name check, so the output file name does not need to end with ".svg".

Thanks for this great utility!

claudep commented 3 years ago

Out of curiosity, what's the use case of skipping the extension control? We might also consider changing the error into a warning (without adding a new option).

ChrisBuergi commented 3 years ago

I have two Python envs where I call "qrbill" via a subprocess and use NamedTemporaryFile to capture the output. I was under the impression, that with NamedTemporaryFile it's not possible to create *.svg files, but I just learned that this is possible with the "suffix" argument. Sorry for my confusion.

So for me the check in the CLI now does not matter, but maybe it would still be nice to have that error converted to a warning for other cases.

claudep commented 3 years ago

I committed your first commit as is, and pushed c287ef717e8ca to change the error into warning. Thanks for your contribution.

ChrisBuergi commented 3 years ago

Ok, perfect. Thank you!