search

claudep / swiss-qr-bill

A Python library to generate Swiss QR-bill payment slips
MIT License
97 stars 39 forks source link

changes due to styleguide #56

Closed AntonMezger closed 3 years ago

AntonMezger commented 3 years ago

The latest version does not follow the guidelines as corrected by UBS. The main things to correct are the following:

QR-Code must be 46x46mm Swiss cross must be 7x7mm the right part must be 5 mm right from the QR-Code the bottom part is also too low

I corrected all this in the attached version, please have a look and perhaps integrate by improving the code

bill.zip

claudep commented 3 years ago

Thanks a lot for the proposed changes! However, the code changed a bit since you amended bill.py. It would be great to check if the latest code (0.6.0) still suffers from the same issues, and in that case, suggest a pull request.

AntonMezger commented 3 years ago

0.6.0 has been tried, but the only thing that seems correct is that the qr-code is sitting 5mm from the cut border. Size is not 46mm, cross is not 7mm and the right part is not sitting 5mm from the qr-code.

claudep commented 3 years ago

I splitted each reported problem to its own issue.

claudep commented 3 years ago

Now the master branch should be in better shape. Would appreciate testing before a release (or other fixes).