amount, pcode, ref_number, extra_infos

claudep / swiss-qr-bill

A Python library to generate Swiss QR-bill payment slips

MIT License

98 stars 39 forks source link

amount, pcode, ref_number, extra_infos #68

Open noem6942 opened 3 years ago

noem6942 commented 3 years ago

Proposals:

type(amount) should be float not str
rename pcode to postal_code as used in common
rename ref_number to reference_number (as in SIX documentation)
rename extra_infos to additional_information (as in SIX documentation)
implement Billing Information (to my understanding it's approved by 1.1.2021)

claudep commented 3 years ago

Would you like to submit patches? In that case, please one change per commit (could be one or several pull requests). The last point probably deserves a separate issue.

noem6942 commented 3 years ago

Point 1 to 4 is trivial to implement without any backwards compatibility - but do you really want this?

claudep commented 3 years ago

Sure, it looks like proper cleanup. It might be a bit less trivial if we want to keep compatibility with old names at entry points (script parameters and QRBill.__init__).

bb1950328 commented 1 year ago

type(amount) should be float not str

this is a bad idea.