clauderic / react-sortable-hoc

A set of higher-order components to turn any list into an animated, accessible and touch-friendly sortable list✌️
https://clauderic.github.io/react-sortable-hoc/
MIT License
10.81k stars 980 forks source link

Scroll issue with table rows #535

Open amitsarwara opened 5 years ago

amitsarwara commented 5 years ago

I have implemented it for table rows. It is working fine i am getting the old and new index. Problem is when my table rows are more and we have to scroll it to get them in view then when i drag the row it till the viewport ends. It is not scrolling the table list as i touched to the top of the window. I was able to do scroll by scroller on mouse but problem is drag is not accepted on the rows that came on screen after scroll.

Can anyone please help me how to diagnose this issue or any suggestion to resolve this problem.

clauderic commented 5 years ago

If believe you've found an issue, please setup a sandbox replicating the issue on CodeSandbox

emeidell commented 5 years ago

I think the basic example does a pretty good job just showing the bug on its own. I forked it and added some more items to show that the scroll is not triggering. I was at first thinking that the scrolling does not work when an axis is locked but it might just be bugged out totally.

https://codesandbox.io/s/react-sortable-hoc-broken-scroll-v005n