search

clauderic / react-sortable-hoc

A set of higher-order components to turn any list into an animated, accessible and touch-friendly sortable list✌️
https://clauderic.github.io/react-sortable-hoc/
MIT License
10.83k stars 983 forks source link

Support React v. 18 #844

Open patrykboch opened 2 years ago

patrykboch commented 2 years ago

Fixes https://github.com/clauderic/react-sortable-hoc/issues/838

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f28d4ac3e508097fa2d5f3fb12594e10e72c5df7:

Sandbox Source
react-sortable-hoc-starter Configuration
patrykboch commented 2 years ago

@clauderic please review

chrishawn commented 2 years ago

yes please review

patrykboch commented 2 years ago

@chrishawn I'm afraid it might never be introduced. The lib is considered deprecated and further enhancements won't be merged. Only security fixes. See @dnd/kit as an alternative.

Anyways migration to @dnd/kit is not obvious and it'd be perfect to have the support of React v18 here. The newest version of React does ensure backward compatibility.

I see that ReactDOM.findDOMnode, ReactDOM.render, etc. are in fact deprecated but it does not mean they neither work with the latest React nor the lib in question. So please, @clauderic consider this.

alexander-schranz commented 2 years ago

Would also like to see this merged. We can also not migrate away currently to another package. So would really like to see 18 official supported here.

arneee commented 2 years ago

@clauderic : Please support that. We are using this package on so many pages so it will be a huge effort to migrate. Since the methods are still there (only deprecated), I really hope that this will be merged. Thanks!!!

SergioArrighi commented 2 years ago

Hello, thanks for your work. Any target date for this to be merged? Best regards

marwin1991 commented 2 years ago

@clauderic Is there any migration guide to dnd-kit?

marco-adapttech commented 2 years ago

Hello,

Any updates for when it will be released?

Thanks everyone for the work.

Artexoid commented 1 year ago

Hi guys, merge it please.