search

clauderic / react-tiny-virtual-list

A tiny but mighty 3kb list virtualization library, with zero dependencies 💪 Supports variable heights/widths, sticky items, scrolling to index, and more!
https://clauderic.github.io/react-tiny-virtual-list/
MIT License
2.46k stars 165 forks source link

fix some issues with scrollToIndex and scrollOffset, when itemPropsHaveChanged is true #17

Closed Dimon70007 closed 7 years ago

Dimon70007 commented 7 years ago

Hi! Thanks for your hard work. This pr fixes scrollToIndex and scrollOffset when itemCount has been changed (adding items to the begin of list). Have a nice day!!!

codecov[bot] commented 7 years ago

Codecov Report

Merging #17 into master will increase coverage by 0.33%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17      +/-   ##
=======================================
+ Coverage   91.66%   92%   +0.33%     
=======================================
  Files           3     4       +1     
  Lines         144   150       +6     
=======================================
+ Hits          132   138       +6     
  Misses         12    12
Impacted Files Coverage Δ
tests/arrGenerator.js 100% <100%> (ø)
src/index.js 84.21% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dcf8b95...f1ee466. Read the comment docs.

Dimon70007 commented 7 years ago

you are welcome!