search

clauderic / react-tiny-virtual-list

A tiny but mighty 3kb list virtualization library, with zero dependencies 💪 Supports variable heights/widths, sticky items, scrolling to index, and more!
https://clauderic.github.io/react-tiny-virtual-list/
MIT License
2.46k stars 166 forks source link

Mark componentWillReceiveProps UNSAFE #81

Open y6nH opened 4 years ago

y6nH commented 4 years ago

See #66. This is the minimum change required for React 17 compatibility. The warning thrown by React 16, for reference:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

      * Move data fetching code or side effects to componentDidUpdate.
      * If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
      * Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.
marsonmao commented 4 years ago

This has to be fixed error: Identifier 'UNSAFE_componentWillReceiveProps' is not in camel case (camelcase) at src/index.tsx:173:3:; guess that adding a eslint disable next line?

y6nH commented 4 years ago

Now it's really broken. I suspect we have to update dependencies.

A one-liner is never a one-liner.