search

claudiajs / claudia-bot-builder

Create chat bots for Facebook Messenger, Slack, Amazon Alexa, Skype, Telegram, Viber, Line, GroupMe, Kik and Twilio and deploy to AWS Lambda in minutes
https://claudiajs.com/claudia-bot-builder.html
MIT License
1.84k stars 253 forks source link

Allow sending multiple responses for GroupMe #109

Open josephfrazier opened 6 years ago

simalexan commented 6 years ago

Hey, this contribution is great! It's very appreciated and thank you for implementing it. We've looked into the code and would only suggest instead of the added dependency for promiseEach, maybe implement it using a similar solution mentioned here https://stackoverflow.com/questions/37916064/sequential-iteration-using-es6-promises

Because Lambda uploads take longer with more dependencies, we tend to keep as few as possible. What do you think?

josephfrazier commented 6 years ago

Thanks for the quick feedback! I copied the promise-each implementation into lib/promise-each.js, modified it to remove dependencies and linting errors, and used it instead. What do you think?

josephfrazier commented 6 years ago

Hey @simalexan, have you had a chance to review the most recent changes? I just stumbled across this again and thought I'd check in.