added url path normalization code to deal with cases of `/../` in the url

claudiajs / claudia-bot-builder

Create chat bots for Facebook Messenger, Slack, Amazon Alexa, Skype, Telegram, Viber, Line, GroupMe, Kik and Twilio and deploy to AWS Lambda in minutes

https://claudiajs.com/claudia-bot-builder.html

MIT License

1.84k stars 253 forks source link

added url path normalization code to deal with cases of `/../` in the url #111

Closed gavinr closed 6 years ago

gavinr commented 6 years ago

see https://developer.amazon.com/docs/custom-skills/host-a-custom-skill-as-a-web-service.html?ref_=pe_3490300_259883220#checking-the-signature-of-the-request - the url https://s3.amazonaws.com/echo.api/../echo.api/echo-api-cert.pem should pass, but was not without this path normalization code.
also added some "todo" comments to track the last items that we need to do for this.

@simalexan please take a look. thanks!

simalexan commented 6 years ago

@gavinr this is great, we can proceed further now. And as you've seen the process is kinda "demoralizing" if you're using an external HTTP service instead of an AWS Lambda function.

simalexan commented 6 years ago

@gavinr We should also add tests along the way, as this seems to be failing the tests.